Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stdarch #91052

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Update stdarch #91052

merged 1 commit into from
Nov 20, 2021

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 19, 2021

5 commits in 815d55c..cfba59f
2021-11-08 00:58:47 +0000 to 2021-11-19 01:29:04 +0000

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Nov 19, 2021

I mistakenly thought #90382 updated stdarch to the latest master, but it was behind by several commits that I need.

@Amanieu
Copy link
Member

Amanieu commented Nov 19, 2021

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Nov 19, 2021

📌 Commit 458ed5a has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2021
@bors
Copy link
Contributor

bors commented Nov 20, 2021

⌛ Testing commit 458ed5a with merge 6d48ee9...

@bors
Copy link
Contributor

bors commented Nov 20, 2021

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 6d48ee9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 20, 2021
@bors bors merged commit 6d48ee9 into rust-lang:master Nov 20, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 20, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6d48ee9): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

  • Very large improvement in instruction counts (up to -5.8% on incr-unchanged builds of inflate)
  • Small regression in instruction counts (up to 0.3% on incr-patched: println builds of html5ever)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Nov 20, 2021
@pnkfelix
Copy link
Member

Visited for weekly performance triage.

The only benchmark that regressed is "html5ever debug" ("incr-patched: println" and "incr-unchanged"), and only by a relatively small amount. This seems acceptable to me, compared to the effort involved in figuring out how this change could be related to that effect.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants