Add -webkit-appearance: none to search input
#91699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
added
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Dec 9, 2021
|
An ipad-specific issue, it's been a while. :) Can you add a comment on the CSS property please? After that, r=me |
camelid
changed the title
-webkit-appearance: none to search input
jsha
force-pushed
the
webkit-appearance-search-input
branch
from
b2784d5 to
a148c69
Compare
This comment has been minimized.
This comment has been minimized.
jsha
force-pushed
the
webkit-appearance-search-input
branch
from
a148c69 to
7c1b7ea
Compare
This comment has been minimized.
This comment has been minimized.
This fixes an issue when displaying on iPad, where the search box had no borders.
jsha
force-pushed
the
webkit-appearance-search-input
branch
from
7c1b7ea to
da472a5
Compare
GuillaumeGomez
approved these changes
Dec 13, 2021
|
Thanks! @bors: r+ rollup |
|
📌 Commit da472a5 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 13, 2021
…, r=GuillaumeGomez Add `-webkit-appearance: none` to search input This fixes an issue when displaying on iPad, where the search box had no borders. r? `@GuillaumeGomez` Demo https://rustdoc.crud.net/jsha/webkit-appearance-search-input/std/string/struct.String.html
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 13, 2021
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#91699 (Add `-webkit-appearance: none` to search input) - rust-lang#91846 (rustdoc: Reduce number of arguments for `run_test` a bit) - rust-lang#91847 (Fix FIXME for `generic_arg_infer` in `create_substs_for_ast_path`) - rust-lang#91849 (GATs outlives lint: Try to prove bounds) - rust-lang#91855 (Stabilize const_cstr_unchecked) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when displaying on iPad, where the search box had no borders.
r? @GuillaumeGomez
Demo https://rustdoc.crud.net/jsha/webkit-appearance-search-input/std/string/struct.String.html