-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Reduce number of arguments for run_test
a bit
#91846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to apply to all doctests in the crate.
These are the rustdoc-wide options. It's easy to confuse them with options for doctests in particular, so this change should help.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ollie27 (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 13, 2021
camelid
added
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
A-doctests
Area: Documentation tests, run by rustdoc
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
labels
Dec 13, 2021
camelid
changed the title
rustdoc: Reduce number of arguments for
rustdoc: Reduce number of arguments for Dec 13, 2021
run_test
run_test
a bit
GuillaumeGomez
approved these changes
Dec 13, 2021
Thanks! @bors: r+ rollup |
📌 Commit 9afa190 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 13, 2021
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 13, 2021
…eGomez rustdoc: Reduce number of arguments for `run_test` a bit - rustdoc: Coalesce some `run_test` args as one `LangString` arg - Rename `TestOptions` to `GlobalTestOptions` - doctest: Rename `options` to `rustdoc_options`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 13, 2021
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#91699 (Add `-webkit-appearance: none` to search input) - rust-lang#91846 (rustdoc: Reduce number of arguments for `run_test` a bit) - rust-lang#91847 (Fix FIXME for `generic_arg_infer` in `create_substs_for_ast_path`) - rust-lang#91849 (GATs outlives lint: Try to prove bounds) - rust-lang#91855 (Stabilize const_cstr_unchecked) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-doctests
Area: Documentation tests, run by rustdoc
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_test
args as oneLangString
argTestOptions
toGlobalTestOptions
options
torustdoc_options