rustdoc: Remove String allocation in iteration in print_generic_bounds
#92283
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
From what I can see, it looks fine. I'd just prefer to have a second opinion (cc @camelid). In the meantime, let's check the impact on perf. @bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit 141c542 with merge 43c0ef59a6d02c4d06e9e7cb93ecf94b313b3646... |
|
☀️ Try build successful - checks-actions |
|
Queued 43c0ef59a6d02c4d06e9e7cb93ecf94b313b3646 with parent 51e8031, future comparison URL. |
|
Finished benchmarking commit (43c0ef59a6d02c4d06e9e7cb93ecf94b313b3646): comparison url. Summary: This change led to moderate relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
|
This looks good to me as well. The new version seems more "semantically correct" anyway. Thanks! @bors r=camelid,GuillaumeGomez rollup=never |
|
📌 Commit 141c542 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 141c542 with merge dfd4b2abd8d7a4c2a0c7787abb581dc2c109735b... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 141c542 with merge c8cc55e3d85ed1006bb1cb69eb2400e8542d8bb2... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry network error |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 141c542 with merge a38515f729cbfe5d8b8667b14b7d5ea03ab666e9... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (8e05bb5): comparison url. Summary: This change led to moderate relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I realized only after making the commit that maybe I shouldn't refer to iteration as looping, but it's close enough)
The string representation of a
clean::GenericBoundinstance (evaluated here) is deterministic for a givenself(the instance),cxandf, and sincecxandfare constant (as far as I can tell) for a given invocation ofprint_generic_bounds,selfis the determining factor. Therefore, using the data inselfshouldn't differ in effect from using its string representation.Given the totality of the function calls needed to evaluate the string representation as well as the actual allocation, at the very least, this shouldn't negatively affect performance.