mk: Fix valgrinding with jemalloc #9237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes valgrind on the linux snapshot bot. The command added here makes us require a fairly recent valgrind.
|
Valgrind 3.8.0 release note says "Non-libc malloc implementations are now supported". I updated Valgrind version requirement on https://github.com/mozilla/rust/wiki/Note-getting-started-developing-Rust accordingly. |
bors
added a commit
that referenced
this pull request
Sep 17, 2013
This fixes valgrind on the linux snapshot bot. The command added here makes us require a fairly recent valgrind.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 28, 2022
Fix `useless_format` spans for `format!("{foo}")`
Fixes rust-lang#9234
changelog: [`useless_format`]: Fix spans for `format!("{foo}")`
rust-lang#94030 made our workaround unneeded, but by coincidence our test still passed [because `Span::new()` swaps `hi` & `lo` if needed](https://github.com/rust-lang/rust/blob/c32dcbba187d1ee0dbe92dc152cb9c2f3f42900c/compiler/rustc_span/src/span_encoding.rs#L86-L88). So with a single character variable like `format!("{x}")` it still worked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes valgrind on the linux snapshot bot. The command added here
makes us require a fairly recent valgrind.