Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix STD compilation for the ESP-IDF target (regression from CVE-2022-21658) #93152

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Fix STD compilation for the ESP-IDF target (regression from CVE-2022-21658) #93152

merged 1 commit into from
Jan 24, 2022

Conversation

ivmarkov
Copy link
Contributor

Commit 54e22eb broke the compilation of STD for the ESP-IDF embedded "unix-like" Tier 3 target, because the fix for CVE-2022-21658 uses libc flags which are not supported on the ESP-IDF platform.

This PR simply redirects the ESP-IDF compilation to the "classic" implementation, similar to REDOX. This should be safe because:

  • Neither of the two filesystems supported by ESP-IDF (spiffs and fatfs) support symlinks in the first place
  • There is no notion of fs permissions at all, as the ESP-IDF is an embedded platform that does not have the notion of users, groups, etc.
  • Similarly, ESP-IDF has just one "process" - the firmware itself - which contains the user code and the "OS" fused together and running with all permissions

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 21, 2022
@ivmarkov ivmarkov mentioned this pull request Jan 21, 2022
Merged
@m-ou-se
Copy link
Member

m-ou-se commented Jan 23, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 23, 2022

📌 Commit 495c7b3 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 24, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2022
@bors
Auto merge of rust-lang#93260 - matthiaskrgr:rollup-c5b9c76, r=matthi…
51126be 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#92513 (std: Implement try_reserve and try_reserve_exact on PathBuf)
 - rust-lang#93152 (Fix STD compilation for the ESP-IDF target (regression from CVE-2022-21658))
 - rust-lang#93186 (Fix link to CVE-2022-21658)
 - rust-lang#93188 (rustdoc: fix bump down typing search on Safari)
 - rust-lang#93212 (Remove unneeded cursor pointer rule on mobile sidebar)
 - rust-lang#93231 (adjust sidebar link brightness)
 - rust-lang#93241 (Fix brief appearance of rust logo in the sidebar)
 - rust-lang#93253 (Update theme on pageshow event)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 144aeed into rust-lang:master Jan 24, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ivmarkov @rust-highfive @m-ou-se @bors @dtolnay @rustbot