adjust sidebar link brightness #93231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
the
T-rustdoc
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @notriddle (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Your new CSS rule doesn't seem to be applied on the current item. Is it voluntary? Here is what the output looks like:
|
|
There seems to be a separate rule which defines the selected item colour: Are you suggesting we should apply the same contrast scaling to these? |
|
If there is a contrast "problem" there as well, then yes. |
This comment has been minimized.
This comment has been minimized.
notriddle
requested changes
Jan 23, 2022
notriddle
approved these changes
Jan 23, 2022
There was a problem hiding this comment.
Needs to fix the sidebar.goml test case failure. Other than that, this looks great. Thanks!
/checkout/src/test/rustdoc-gui/sidebar.goml sidebar... FAILED
9846
Error: (line 12) Error: Evaluation failed: expected `rgb(56, 115, 173)` for key `color` for selector `#all-types`, found `rgb(53, 109, 164)`: for command `assert-css: ("#all-types", {"color": "rgb(56, 115, 173)"})`
|
Very nice, thanks for working on this! Related to: #93230 |
|
@bors r+ |
|
📌 Commit ca3d0e2 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92513 (std: Implement try_reserve and try_reserve_exact on PathBuf) - rust-lang#93152 (Fix STD compilation for the ESP-IDF target (regression from CVE-2022-21658)) - rust-lang#93186 (Fix link to CVE-2022-21658) - rust-lang#93188 (rustdoc: fix bump down typing search on Safari) - rust-lang#93212 (Remove unneeded cursor pointer rule on mobile sidebar) - rust-lang#93231 (adjust sidebar link brightness) - rust-lang#93241 (Fix brief appearance of rust logo in the sidebar) - rust-lang#93253 (Update theme on pageshow event) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Merged
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 25, 2022
…illaumeGomez minor fix for rust-lang#93231 In rust-lang#93231 I introduced the new sidebar colours to make the contrast more balanced and easier to read, but it seems I made a copy-paste error in the light theme, resulting in functions appearing green. This one line change replaces that colour with it's corrected orange/brown colour. I have double checked the rest of the colours and they seem ok. Sorry for the inconvenience
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 25, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#93250 (Remove deduplication of early lints) - rust-lang#93286 (Add white-space: nowrap to links in the sidebar) - rust-lang#93291 (minor fix for rust-lang#93231) - rust-lang#93300 (make Windows abort_internal Miri-compatible) - rust-lang#93303 (Fix ICE when parsing bad turbofish with lifetime argument) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly simple change. I've taken the existing link colour and main body background colours, and made sure that the sidebar+link contrast is the same.
ayu:
dark:
light: