Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NonNull::new const #93236

Merged
merged 2 commits into from
Jan 29, 2022
Merged

Make NonNull::new const #93236

merged 2 commits into from
Jan 29, 2022

Conversation

lilasta
Copy link
Contributor

@lilasta lilasta commented Jan 23, 2022

Tracking issue: #93235

@lilasta
Copy link
Contributor Author

lilasta commented Jan 24, 2022

@rustbot label +S-waiting-on-review +T-libs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 24, 2022
@lilasta lilasta mentioned this pull request Jan 24, 2022
Closed
4 tasks
@lilasta
Copy link
Contributor Author

lilasta commented Jan 24, 2022

r? @oli-obk

(is rust-highfive stopped...?)

@oli-obk
Copy link
Contributor

oli-obk commented Jan 25, 2022

lgtm, please add tests of this function being used in a const item (one for Some and one for None).

@lilasta
Copy link
Contributor Author

lilasta commented Jan 28, 2022

Added.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 28, 2022

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 28, 2022

📌 Commit cdd0873 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 29, 2022
@matthiaskrgr
Rollup merge of rust-lang#93236 - woppopo:const_nonnull_new, r=oli-obk
5cbe671 
Make `NonNull::new` `const`

Tracking issue: rust-lang#93235
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 29, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 29, 2022
@matthiaskrgr
Rollup merge of rust-lang#93236 - woppopo:const_nonnull_new, r=oli-obk
cb97b8a 
Make `NonNull::new` `const`

Tracking issue: rust-lang#93235
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 29, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2022
@bors
Auto merge of rust-lang#93457 - matthiaskrgr:rollup-e43ry1l, r=matthi…
a00e130 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#88205 (Add Explanation For Error E0772)
 - rust-lang#92274 (Add `intrinsics::const_deallocate`)
 - rust-lang#93236 (Make `NonNull::new` `const`)
 - rust-lang#93299 (Fix dot separator when there is no source link)
 - rust-lang#93410 (kmc-solid: Implement `net::FileDesc::duplicate`)
 - rust-lang#93424 (fix nit)
 - rust-lang#93431 (remove unused `jemallocator` crate)
 - rust-lang#93453 (Add GUI theme change test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 37e9cb3 into rust-lang:master Jan 29, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 29, 2022
@lilasta lilasta deleted the const_nonnull_new branch January 30, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lilasta @oli-obk @bors @rustbot