remove unused jemallocator crate
#93431
Conversation
rustbot
added
the
T-compiler
|
@bors try @rust-timer queue to make sure perf doesn't regress unexpectedly, and Felix seemed interested in having dependency updates PR be ran through perf.rlo prior to merging. |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit f9e0eb3 with merge cb76fa9b541f4139456ea66e2bed9241f684661b... |
|
☀️ Try build successful - checks-actions |
|
Queued cb76fa9b541f4139456ea66e2bed9241f684661b with parent 427eba2, future comparison URL. |
|
Finished benchmarking commit (cb76fa9b541f4139456ea66e2bed9241f684661b): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
rustbot
added
S-waiting-on-review
|
It's likely safe to rollup then, wdyt ? (There was still a segfault in |
|
@bors r+ rollup Agreed. |
|
📌 Commit f9e0eb3 has been approved by |
bors
added
S-waiting-on-bors
…ulacrum remove unused `jemallocator` crate When it was noticed that the rustc binary wasn't actually using jemalloc via `#[global_allocator]` and that was removed, the dependency remained. Tests pass locally with a `jemalloc = true` build, but I'll trigger a try build to ensure I haven't missed an edge-case somewhere. r? `@ghost` until that completes
…ulacrum remove unused `jemallocator` crate When it was noticed that the rustc binary wasn't actually using jemalloc via `#[global_allocator]` and that was removed, the dependency remained. Tests pass locally with a `jemalloc = true` build, but I'll trigger a try build to ensure I haven't missed an edge-case somewhere. r? ``@ghost`` until that completes
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#88205 (Add Explanation For Error E0772) - rust-lang#92274 (Add `intrinsics::const_deallocate`) - rust-lang#93236 (Make `NonNull::new` `const`) - rust-lang#93299 (Fix dot separator when there is no source link) - rust-lang#93410 (kmc-solid: Implement `net::FileDesc::duplicate`) - rust-lang#93424 (fix nit) - rust-lang#93431 (remove unused `jemallocator` crate) - rust-lang#93453 (Add GUI theme change test) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
When it was noticed that the rustc binary wasn't actually using jemalloc via
#[global_allocator]and that was removed, the dependency remained.Tests pass locally with a
jemalloc = truebuild, but I'll trigger a try build to ensure I haven't missed an edge-case somewhere.r? @ghost until that completes