Test leaking of BinaryHeap Drain iterators #94145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @Amanieu since some of these tests relate to panic-in-drop. |
|
These tests are fine for now, we'll probably revisit them when we change the default for panic-in-drop. |
|
☔ The latest upstream changes (presumably #94824) made this pull request unmergeable. Please resolve the merge conflicts. |
ssomers
force-pushed
the
binary_heap_tests
branch
from
7eb9dd1
to
0ee76a3
Compare
JohnCSimon
added
S-waiting-on-review
rustbot
added
the
T-libs
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 28, 2022
Test leaking of BinaryHeap Drain iterators Add test cases about forgetting the `BinaryHeap::Drain` iterator, and slightly fortifies some other test cases. Consists of separate commits that I don't think are relevant on their own (but I'll happily turn these into more PRs if desired).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 28, 2022
…fee1-dead Rollup of 9 pull requests Successful merges: - rust-lang#94145 (Test leaking of BinaryHeap Drain iterators) - rust-lang#103945 (Remove `iter::Empty` hack) - rust-lang#104024 (Fix `unused_must_use` warning for `Box::from_raw`) - rust-lang#104708 (Fix backoff doc to match implementation) - rust-lang#105347 (Account for `match` expr in single line) - rust-lang#105484 (Implement allow-by-default `multiple_supertrait_upcastable` lint) - rust-lang#106184 (Fix `core::any` docs) - rust-lang#106201 (Emit fewer errors on invalid `#[repr(transparent)]` on `enum`) - rust-lang#106205 (Remove some totally duplicated files in `rustc_infer`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test cases about forgetting the
BinaryHeap::Drainiterator, and slightly fortifies some other test cases.Consists of separate commits that I don't think are relevant on their own (but I'll happily turn these into more PRs if desired).