-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TLS __getit #[inline(always)] on non-Windows #94373
Conversation
This may improve perf.
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 2d6d30f with merge 7cda7542c9f3a3ff64bb19fd207c2d03fb2ef36c... |
☀️ Try build successful - checks-actions |
Queued 7cda7542c9f3a3ff64bb19fd207c2d03fb2ef36c with parent d981633, future comparison URL. |
Finished benchmarking commit (7cda7542c9f3a3ff64bb19fd207c2d03fb2ef36c): comparison url. Summary: This benchmark run shows 1 relevant improvement 🎉 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
@bors r+ I think this likely won't hurt, at minimum, and may help fix some perf noise. |
📌 Commit 2d6d30f has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (035a717): comparison url. Summary: This benchmark run shows 1 relevant improvement 🎉 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This may improve perf, and/or stop
externs
perf benchmarks from being flaky.r? @ghost