-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #94431
Rollup of 7 pull requests #94431
Conversation
It is currently hard coded to llvm if enabled and cranelift otherwise. This made some sense when cranelift was the only alternative codegen backend. Since the introduction of the gcc backend this doesn't make much sense anymore. Before this PR bootstrapping rustc using a backend other than llvm or cranelift required changing the source of rustc_interface. With this PR it becomes a matter of putting the right backend as first enabled backend in config.toml.
Continuation of rust-lang#94376. cc rust-lang#53667
…an-DPC 1 - Make more use of `let_chains` Continuation of rust-lang#94376. cc rust-lang#53667
…ion, r=cjgillot Document that pre-expansion lint passes are softly deprecated The pre-expansion lint pass has been softly deprecated since rust-lang#69838. Every once in a while I see someone mention it as a possibility, only get the feedback that it's deprecated. This PR officially documents that the method is soft deprecated to have a single point of truth for it. That's it. Have a great rest of the day 🙃 --- * See [rust#69838](rust-lang#69838) * See [rust-clippy#5518](rust-lang/rust-clippy#5518)
…5, r=matthiaskrgr Add test for rust-lang#79465 to prevent regression Fixes rust-lang#79465. Like this we will be able to close the issue. r? ````@matthiaskrgr````
avoid rebuilding bootstrap when PATH changes Fixes rust-lang#94408 r? ```@Mark-Simulacrum```
…Simulacrum Use the first codegen backend in the config.toml as default It is currently hard coded to llvm if enabled and cranelift otherwise. This made some sense when cranelift was the only alternative codegen backend. Since the introduction of the gcc backend this doesn't make much sense anymore. Before this PR bootstrapping rustc using a backend other than llvm or cranelift required changing the source of rustc_interface. With this PR it becomes a matter of putting the right backend as first enabled backend in config.toml. cc ```@antoyo```
…links, r=notriddle Fix duplicated impl links Fixes rust-lang#78701. The problem is that the blanket impl has the same ID as the other impl, except that we don't derive IDs when we generate the sidebar. We now do. r? ``@notriddle``
3 - Make more use of `let_chains` Continuation of rust-lang#94376. cc rust-lang#53667
@bors r+ rollup=never p=7 |
📌 Commit 5570b1d has been approved by |
⌛ Testing commit 5570b1d with merge 238aa5f6e1eadca52671b7e4a2e12035df23b6be... |
💔 Test failed - checks-actions |
@bors retry |
⌛ Testing commit 5570b1d with merge 7662a8f8f32b78e21867ad1092b858dacb6bd367... |
💔 Test failed - checks-actions |
@bors retry one more retry... auto (dist-i686-mingw, --build=i686-pc-windows-gnu --enable-full-tools --enable-profiler, python ... |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b07d59f): comparison url. Summary: This benchmark run shows 4 relevant regressions 😿 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
Successful merges:
let_chains
#94396 (1 - Make more use oflet_chains
)let_chains
#94420 (3 - Make more use oflet_chains
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup