-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicated impl links #94417
Merged
bors
merged 2 commits into
rust-lang:master
from
GuillaumeGomez:fix-duplicated-impl-links
Feb 28, 2022
Merged
Fix duplicated impl links #94417
bors
merged 2 commits into
rust-lang:master
from
GuillaumeGomez:fix-duplicated-impl-links
Feb 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
label
Feb 27, 2022
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Feb 27, 2022
The job Click to see the possible cause of the failure (guessed by this bot)
|
Spurious failure. I'll really need to try to prevent it somehow... |
@bors r+ |
📌 Commit 9b8a6b9 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 27, 2022
notriddle
approved these changes
Feb 27, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 27, 2022
…links, r=notriddle Fix duplicated impl links Fixes rust-lang#78701. The problem is that the blanket impl has the same ID as the other impl, except that we don't derive IDs when we generate the sidebar. We now do. r? `@notriddle`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 28, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#94396 (1 - Make more use of `let_chains`) - rust-lang#94397 (Document that pre-expansion lint passes are softly deprecated) - rust-lang#94399 (Add test for rust-lang#79465 to prevent regression) - rust-lang#94409 (avoid rebuilding bootstrap when PATH changes) - rust-lang#94415 (Use the first codegen backend in the config.toml as default) - rust-lang#94417 (Fix duplicated impl links) - rust-lang#94420 (3 - Make more use of `let_chains`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78701.
The problem is that the blanket impl has the same ID as the other impl, except that we don't derive IDs when we generate the sidebar. We now do.
r? @notriddle