Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass LLVM string attributes as string slices #94539

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Pass LLVM string attributes as string slices #94539

merged 1 commit into from
Mar 4, 2022

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Mar 2, 2022

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 2, 2022
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2022
@nikic
Copy link
Contributor

nikic commented Mar 3, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 3, 2022

📌 Commit 926bf1a has been approved by nikic

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2022
@oli-obk oli-obk assigned nikic and unassigned oli-obk Mar 3, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 3, 2022
@Dylan-DPC
Rollup merge of rust-lang#94539 - tmiasko:string-attributes, r=nikic
b56c1d8 
Pass LLVM string attributes as string slices
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 3, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 3, 2022
@Dylan-DPC
Rollup merge of rust-lang#94539 - tmiasko:string-attributes, r=nikic
e5db9fe 
Pass LLVM string attributes as string slices
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 3, 2022
Closed
@tmiasko tmiasko mentioned this pull request Mar 3, 2022
Merged
@nagisa
Copy link
Member

nagisa commented Mar 3, 2022

@bors rollup=never (perf implications)

@bors
Copy link
Contributor

bors commented Mar 4, 2022

⌛ Testing commit 926bf1a with merge 047f9c4...

@bors
Copy link
Contributor

bors commented Mar 4, 2022

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 047f9c4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 4, 2022
@bors bors merged commit 047f9c4 into rust-lang:master Mar 4, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 4, 2022
@tmiasko tmiasko deleted the string-attributes branch March 4, 2022 13:16
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (047f9c4): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@madsmtm madsmtm mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikic nikic

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
8 participants
@tmiasko @rust-highfive @nikic @bors @nagisa @rust-timer @oli-obk @rustbot