Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ordering traits from rustc_span::hygiene::LocalExpnId #94614

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

pierwill
Copy link
Member

@pierwill pierwill commented Mar 4, 2022

Part of work on #90317.

Also adds a negative impl block as a form of documentation and a roadblock to regression.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 4, 2022
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2022
@pierwill pierwill force-pushed the localexpnid-noord branch from 4d722da to 98fe2eb Compare March 4, 2022 17:00
@lcnr
Copy link
Contributor

lcnr commented Mar 7, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 7, 2022

📌 Commit 98fe2eb has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2022
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#94553 (add tests for rust-lang#94502)
 - rust-lang#94614 (Remove ordering traits from `rustc_span::hygiene::LocalExpnId`)
 - rust-lang#94685 (interpret: move saturating_add/sub into (pub) helper method)
 - rust-lang#94688 (Erase regions when checking for missing Copy predicates)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 87df3f6 into rust-lang:master Mar 7, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 7, 2022
@pierwill pierwill deleted the localexpnid-noord branch March 7, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants