Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erase regions when checking for missing Copy predicates #94688

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Erase regions when checking for missing Copy predicates #94688

merged 1 commit into from
Mar 7, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #94662

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 7, 2022
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2022
compiler-errors
compiler-errors commented Mar 7, 2022
View reviewed changes
compiler/rustc_borrowck/src/diagnostics/conflict_errors.rs
cause,
);
// Select all, including ambiguous predicates
let errors = fulfill_cx.select_all_or_error(&infcx);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a drive-by, I can revert it if it's useless. I thought we should also process ambiguous predicates below, not just the definitely-error ones.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 7, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 7, 2022

📌 Commit 5ddaa2d has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 7, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2022
@bors
Auto merge of rust-lang#94695 - matthiaskrgr:rollup-5pi3acz, r=matthi…
d137c3a 
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#94553 (add tests for rust-lang#94502)
 - rust-lang#94614 (Remove ordering traits from `rustc_span::hygiene::LocalExpnId`)
 - rust-lang#94685 (interpret: move saturating_add/sub into (pub) helper method)
 - rust-lang#94688 (Erase regions when checking for missing Copy predicates)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c0c452b into rust-lang:master Mar 7, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 7, 2022
@compiler-errors compiler-errors mentioned this pull request Mar 16, 2022
Closed
@compiler-errors compiler-errors deleted the free-regions-in-copy-predicate-check branch April 7, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

nightly: ICE: borrow checker panic instead of error on borrow of moved value
5 participants
@compiler-errors @rust-highfive @oli-obk @bors @rustbot