interpret: err instead of ICE on size mismatches in to_bits_or_ptr_internal #95785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did this a while ago already for
to_i32()
and friends, but missed this one. That became quite annoying when I was debugging an ICE caused byread_pointer
in a Miri shim where the code was passing an argument at the wrong type.Having
scalar_to_ptr
be fallible is consistent with all the otherScalar::to_*
methods being fallible. I addedunwrap
only in code outside the interpreter, which is no worse off than before now in terms of panics.r? @oli-obk