Rollup of 7 pull requests #95838
Closed
Rollup of 7 pull requests #95838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a repeat for Rc of e0e64a8, which cleaned up the same thing for Arc.
This saves an instruction compared to the previous approach, which was to unset the fifth bit with bitwise OR.
…Gomez Hide cross-crate `#[doc(hidden)]` associated items in trait impls Fixes rust-lang#95717. r? ``@GuillaumeGomez`` This is the bug I ran into in rust-lang#95316. ``@rustbot`` label T-rustdoc A-cross-crate-reexports
…=oli-obk interpret: err instead of ICE on size mismatches in to_bits_or_ptr_internal We did this a while ago already for `to_i32()` and friends, but missed this one. That became quite annoying when I was debugging an ICE caused by `read_pointer` in a Miri shim where the code was passing an argument at the wrong type. Having `scalar_to_ptr` be fallible is consistent with all the other `Scalar::to_*` methods being fallible. I added `unwrap` only in code outside the interpreter, which is no worse off than before now in terms of panics. r? ```@oli-obk```
fix unused constant warning on some Windows targets When none of those `cfg_if!` apply (and on Miri), the constant remains unused.
Left overs of rust-lang#95761 These are just nits. Feel free to close this PR if all modifications are not worth merging. * `#![feature(decl_macro)]` is not needed anymore in `rustc_expand` * `tuple_impls` does not require `$Tuple:ident`. I guess it is there to enhance readability? r? `@petrochenkov`
…-remove-unnecessary-nesting-in-rustc-borrowck, r=davidtwco Use `format-args-capture` and remove unnecessary nested blocks
hide another #[allow] directive from a docs example This is a repeat for Rc of e0e64a8, which cleaned up the same thing for Arc.
Use bitwise XOR in to_ascii_uppercase This saves an instruction compared to the previous approach, which was to unset the fifth bit with bitwise OR. Comparison of generated assembly on x86: https://godbolt.org/z/GdfvdGs39 This can also affect autovectorization, saving SIMD instructions as well: https://godbolt.org/z/cnPcz75T9 Not sure if `u8::to_ascii_lowercase` should also be changed, since using bitwise OR for that function does not require an extra bitwise negate since the code is setting a bit rather than unsetting a bit. `char::to_ascii_uppercase` already uses XOR, so no change seems to be required there.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=7 |
|
📌 Commit e53ba18 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit e53ba18 with merge eac79e078b528127daf51663e37fd2235e1dba87... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[doc(hidden)]associated items in trait impls #95769 (Hide cross-crate#[doc(hidden)]associated items in trait impls)macro_metavar_expr#95761)format-args-captureand remove unnecessary nested blocks #95810 (Useformat-args-captureand remove unnecessary nested blocks)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup