Skip to content

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Apr 25, 2022

@rust-highfive
Copy link
Contributor

r? @cuviper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2022
@cuviper
Copy link
Member

cuviper commented Apr 25, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 25, 2022

📌 Commit 91f1eaa has been approved by cuviper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2022
@tmandry
Copy link
Member Author

tmandry commented Apr 25, 2022

@bors rollup=iffy

This can probably be rolled up – the changes are pretty small – but I know rollups tend to avoid these anyway.

@bors
Copy link
Collaborator

bors commented Apr 26, 2022

⌛ Testing commit 91f1eaa with merge 1c988cf...

@bors
Copy link
Collaborator

bors commented Apr 26, 2022

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 1c988cf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 26, 2022
@bors bors merged commit 1c988cf into rust-lang:master Apr 26, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 26, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1c988cf): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 0 0 1 0
mean2 N/A N/A N/A -1.7% N/A
max N/A N/A N/A -1.7% N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@tmandry tmandry deleted the roll-llvm branch April 29, 2022 04:28
@workingjubilee workingjubilee added the O-fuchsia Operating system: Fuchsia label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. O-fuchsia Operating system: Fuchsia S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants