Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more eslint rules #96835

Merged
merged 2 commits into from
May 8, 2022
Merged

Add more eslint rules #96835

merged 2 commits into from
May 8, 2022

Conversation

GuillaumeGomez
Copy link
Member

Slowly continuing to enforce more rules with eslint.

Part of #93058.

r? @notriddle

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-js Area: Rustdoc's JS front-end labels May 8, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2022
@notriddle
Copy link
Contributor

I don’t think either of these actually do anything for us, since ./x.py test tidy already does these things. But sure, might as well.

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented May 8, 2022

📌 Commit 1e93165 has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request May 8, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 8, 2022
@bors
Auto merge of rust-lang#96846 - matthiaskrgr:rollup-yxu9ot9, r=matthi…
cb12198 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#96617 (Fix incorrect syntax suggestion with `pub async fn`)
 - rust-lang#96828 (Further elaborate the lack of guarantees from `Hasher`)
 - rust-lang#96829 (Fix the `x.py clippy` command)
 - rust-lang#96830 (Add and tweak const-generics tests)
 - rust-lang#96835 (Add more eslint rules)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 43b3a49 into rust-lang:master May 8, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 8, 2022
@GuillaumeGomez GuillaumeGomez deleted the eslint-rules branch May 9, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rust-highfive @notriddle @bors @rustbot