Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rustc-perf benchmarks #97044

Merged
merged 1 commit into from
May 14, 2022
Merged

Fix rustc-perf benchmarks #97044

merged 1 commit into from
May 14, 2022

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented May 14, 2022

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2022
@Urgau Urgau force-pushed the check-cfg-fix-rustc-perf branch from b9e7802 to 9a4285c Compare May 14, 2022 14:18
@Urgau Urgau mentioned this pull request May 14, 2022
Closed
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

@bors
Copy link
Contributor

bors commented May 14, 2022

📌 Commit 9a4285c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2022
@bors
Copy link
Contributor

bors commented May 14, 2022

⌛ Testing commit 9a4285c with merge 70b3681...

@bors
Copy link
Contributor

bors commented May 14, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 70b3681 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 14, 2022
@bors bors merged commit 70b3681 into rust-lang:master May 14, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 14, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (70b3681): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@Urgau Urgau mentioned this pull request May 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 4, 2022
@bors
Auto merge of rust-lang#97529 - Urgau:bootstrap-check-cfg-features, r…
3a8e713 
…=Mark-Simulacrum

Use new cargo argument in bootstrap for cfg checking

This PR use new cargo argument in bootstrap for doing cfg checking.

Follow-up to rust-lang#97044 and rust-lang#97214.

r? `@Mark-Simulacrum`
@Urgau Urgau deleted the check-cfg-fix-rustc-perf branch May 5, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Urgau @rust-highfive @Mark-Simulacrum @bors @rust-timer @rustbot