Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tendril #98411

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Update tendril #98411

merged 1 commit into from
Jun 24, 2022

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jun 22, 2022

The 0.4.1 version of tendril (used by mdbook) triggers the unaligned_references lint which is now reported as a future-compatibility warning as of #95372. This updates it to 0.4.3 which does not trigger the warning. This update also triggered the update of futf from 0.1.4 to 0.1.5.

tendril changes: servo/tendril@v0.4.1...v0.4.3
futf changes: servo/futf@v0.1.4...v0.1.5

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2022
@ehuss
Copy link
Contributor Author

ehuss commented Jun 23, 2022

@Mark-Simulacrum I'm curious if you have any opinions about somehow denying these warnings? It is not currently possible AFAIK, but it might be helpful to uncover these hidden warnings.

@Mark-Simulacrum
Copy link
Member

Do you have a reference/link for how to reproduce the warning?

Maybe we could use the force lint level to bypass cap-lints...

I'm a little worried that we might experience these lints during beta bumps in practice (when they're newly introduced via bootstrap tools), which seems like a bad time for them to appear... normally new lints are in-tree so we can easily enough fix them, but in dependencies that's not the case.

One solution could be toolstate-like denies, maybe.

@Mark-Simulacrum
Copy link
Member

r=me on the PR itself though

@ehuss
Copy link
Contributor Author

ehuss commented Jun 23, 2022

./x.py build src/tools/rustbook --stage=0 will show the warning. It looks like this:

warning: the following packages contain code that will be rejected by a future version of Rust: tendril v0.4.1
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`

-F unaligned_references doesn't work because of the way it interacts with --cap-lints (cap-lints "wins").

I think in order to deny these warnings, there will either need to be something added to rustc or cargo. I'm guessing cargo. I think my idea was to have the ability to control lint levels from cargo, and have this be just another control (like "deny" cargo::future_incompat). Unfortunately that project has been stuck for a while (rust-lang/cargo#5034).

I'm not sure what is meant by "toolstate-like denies". If that is something like "future-incompat warnings exist" is an entry in the toolstate database, that would help with exposing the warnings more visibly. I'm not sure how that could work. Unfortunately Cargo doesn't emit any sort of JSON messages to help here.

The hope was that these kinds of warnings would be extremely rare, but perhaps that was wishful thinking on my part.

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jun 23, 2022

📌 Commit 04b75a7 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jun 23, 2022

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 24, 2022
Rollup of 9 pull requests

Successful merges:

 - rust-lang#91264 (Add macro support in jump to definition feature)
 - rust-lang#96955 (Remove (transitive) reliance on sorting by DefId in pretty-printer)
 - rust-lang#97633 (Session object: Set OS/ABI)
 - rust-lang#98039 (Fix `panic` message for `BTreeSet`'s `range` API and document `panic` cases)
 - rust-lang#98214 (rustc_target: Remove some redundant target properties)
 - rust-lang#98280 (Improve suggestion for calling fn-like expr on type mismatch)
 - rust-lang#98394 (Fixup missing renames from `#[main]` to `#[rustc_main]`)
 - rust-lang#98411 (Update tendril)
 - rust-lang#98419 (Remove excess rib while resolving closures)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d26b03c into rust-lang:master Jun 24, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants