rustc_target: Remove some redundant target properties #98214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_like_emscripten
is equivalent toos == "emscripten"
, so it's removed.is_like_fuchsia
is equivalent toos == "fuchsia"
, so it's removed.is_like_osx
also falls into the same category and is equivalent tovendor == "apple"
, but it's commonly used so I kept it as is for now.is_like_(solaris,windows,wasm)
are combinations of different operating systems or architectures (see compiler/rustc_target/src/spec/tests/tests_impl.rs) so they are also kept as is.I think
is_like_wasm
(and maybeis_like_osx
) are sufficiently closed sets, so we can remove these fields as well and replace them with methods likefn is_like_wasm() { arch == "wasm32" || arch == "wasm64" }
.On other hand,
is_like_solaris
andis_like_windows
are sufficiently open and I can imagine custom targets introducing other values foros
.This is kind of a gray area.