rustc_passes/src/entry.rs: De-duplicate more code with fn throw_attr_err()
#98501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can re-use the code for other attributes later.
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Enselic
changed the title
fn throw_attr_err()fn throw_attr_err()
23 tasks
|
@bors r+ rollup |
|
📌 Commit 4731d4b has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 4, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#98501 (rustc_passes/src/entry.rs: De-duplicate more code with `fn throw_attr_err()`) - rust-lang#98774 (rustdoc: make source sidebar toggle a real button) - rust-lang#98806 (Fix long declaration trailing whitespace) - rust-lang#98823 (Fix rust-call ICE in mir-inliner) - rust-lang#98870 (Add regression test for rust-lang#86784) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can more easily re-use the code for other attributes later. More specifically
#[unix_sigpipe]. This refactoring is covered by this test:rust/src/test/ui/feature-gates/issue-43106-gating-of-builtin-attrs-error.rs
Line 120 in 8aab472
(Well, only
#[start], but the code for#[rustc_main]is identical.)