rustdoc: make source sidebar toggle a real button #98774
Conversation
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire |
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Since you added the possibility to focus on the button, can you add a GUI test for it please? |
notriddle
force-pushed
the
notriddle/source-code-sidebar-button
branch
from
7afc6db
to
0d8974b
Compare
Okay, test case added. |
|
☔ The latest upstream changes (presumably #98781) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Looks good to me, thanks! Please fix the merge conflict then I'll make a final review before approving it. |
This fixes tab focus, so that you can open and close the sidebar from keyboard.
notriddle
force-pushed
the
notriddle/source-code-sidebar-button
branch
from
cbdf33a
to
26dccbf
Compare
|
@GuillaumeGomez Okay, I've rebased it. |
| @@ -418,7 +418,7 @@ nav.sub { | |||
| background-color: var(--sidebar-background-color); | |||
| } | |||
|
|
|||
| #sidebar-toggle:hover { | |||
| #sidebar-toggle > button:hover:hover, #sidebar-toggle > button:focus { | |||
There was a problem hiding this comment.
🤦
Pushed commit to fix that.
|
Thanks! @bors r+ rollup |
|
📌 Commit 9938d56 has been approved by |
bors
added
S-waiting-on-bors
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#98501 (rustc_passes/src/entry.rs: De-duplicate more code with `fn throw_attr_err()`) - rust-lang#98774 (rustdoc: make source sidebar toggle a real button) - rust-lang#98806 (Fix long declaration trailing whitespace) - rust-lang#98823 (Fix rust-call ICE in mir-inliner) - rust-lang#98870 (Add regression test for rust-lang#86784) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This fixes tab focus, so that you can open and close the sidebar from keyboard.
This should cause no visible change in appearance at all. The only way you'd know anything different is if you tried to use keyboard controls to open the source code file navigation sidebar.
Separated out from #98772