Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc-guide to rustc-dev-guide transition #602

Closed
28 tasks done
chrissimpkins opened this issue Mar 6, 2020 · 25 comments
Closed
28 tasks done

rustc-guide to rustc-dev-guide transition #602

chrissimpkins opened this issue Mar 6, 2020 · 25 comments
Assignees
@spastorino @chrissimpkins @mark-i-m @LeSeulArtichaut

Comments

@chrissimpkins
Copy link
Member

chrissimpkins commented Mar 6, 2020 •
edited by mark-i-m
Loading

The rustc-guide is being renamed to the rustc-dev-guide. The discussion thread for this decision is #470.

This thread is a record of the work in progress to make the transition.

cc @rust-lang/wg-learning
This work is part of the Learning WG Mar/April 2020 sprint
Zulip thread
chrissimpkins added a commit to chrissimpkins/blog.rust-lang.org that referenced this issue Mar 6, 2020
@chrissimpkins
transition rustc-guide to rustc-dev-guide
713564c 
rust-lang/rustc-dev-guide#602
@chrissimpkins chrissimpkins mentioned this issue Mar 6, 2020
Merged
chrissimpkins added a commit to chrissimpkins/const-eval that referenced this issue Mar 6, 2020
@chrissimpkins
update rustc-guide to rustc-dev-guide
c078ac1 
rust-lang/rustc-dev-guide#602
@chrissimpkins chrissimpkins mentioned this issue Mar 6, 2020
Merged
chrissimpkins added a commit to chrissimpkins/compiler-team that referenced this issue Mar 6, 2020
@chrissimpkins
Transition rustc-guide to rustc-dev-guide
7e10583 
rust-lang/rustc-dev-guide#602
This was referenced Mar 6, 2020
Merged
Merged
Merged
chrissimpkins added a commit to chrissimpkins/chalk that referenced this issue Mar 6, 2020
@chrissimpkins
update rustc-guide to rustc-dev-guide
61d7e6c 
rust-lang/rustc-dev-guide#602
This was referenced Mar 6, 2020
Merged
Merged
@JohnTitor
Copy link
Member

I don't think we need a PR for rust-gha repo.

chrissimpkins added a commit to chrissimpkins/lang-team that referenced this issue Mar 6, 2020
@chrissimpkins
transition rustc-guide to rustc-dev-guide
61e7a06 
rust-lang/rustc-dev-guide#602
This was referenced Mar 6, 2020
Merged
Merged
@chrissimpkins
Copy link
Member Author

Thanks @JohnTitor. I removed it from the list.

@chrissimpkins
Copy link
Member Author

All renaming PR's are in place with [Do not merge yet] titles except for rust-lang/prev.rust-lang.org where the repository README indicates that it has been deprecated since 2018 and there are no commits since 2018... I can push a PR there today if anyone feels that is a blocker. IMO we are ready for the repository rename.

@spastorino
Copy link
Member

I don't think we need a PR for rust-gha repo.

why do you say so?. I found in the README a link to rustc guide which I guess should be updated? or is the information from there automatically updated from elsewhere?.

@chrissimpkins
Copy link
Member Author

Added https://github.com/rust-lang-nursery/rust-lang-nursery.github.io to the rename PR list

@JohnTitor
Copy link
Member

why do you say so?

The repository is only for testing GitHub Actions and I think it's unlikely that anyone will refer to it.

@chrissimpkins
Copy link
Member Author

Added #470 (comment) to the TODO list (update redirects from rustc-guide to rustc-dev-guide. We need to locate who can do this.

@mark-i-m
Copy link
Member

mark-i-m commented Mar 6, 2020

Perhaps @Mark-Simulacrum can guide us in how to set up a GH Pages site for this?

@spastorino
Copy link
Member

I think we should:

  1. rename rustc-guide to rustc-dev-guide repo
  2. create a fresh rustc-guide repo
  3. adjust the description and README to note that the repo has migrate to rustc-dev-guide
  4. redirect all the existing links from rustc-guide to rustc-dev-guide. For that we need to recreate the directory structure of the guide with index.html files that redirect to rustc-dev-guide

@LeSeulArtichaut LeSeulArtichaut mentioned this issue Mar 6, 2020
Merged
@chrissimpkins chrissimpkins mentioned this issue Mar 7, 2020
Closed
@chrissimpkins
Copy link
Member Author

chrissimpkins commented Mar 7, 2020 •
edited
Loading

I think we should:

  1. rename rustc-guide to rustc-dev-guide repo
  2. create a fresh rustc-guide repo
  3. adjust the description and README to note that the repo has migrate to rustc-dev-guide
  4. redirect all the existing links from rustc-guide to rustc-dev-guide. For that we need to recreate the directory structure of the guide with index.html files that redirect to rustc-dev-guide

@spastorino @mark-i-m We still need to identify an admin for (1) - (~3). @LeSeulArtichaut is planning to take care of (4)

@chrissimpkins
Copy link
Member Author

Added Rust Internals forum notification and Inside Rust Blog notification to the TODO list (#470 (comment))

@mark-i-m
Copy link
Member

mark-i-m commented Mar 7, 2020

Thanks @chrissimpkins! I don't mind doing those two items, if you want to assign me

@chrissimpkins
Copy link
Member Author

@mark-i-m Ty! Assigned in the TODO list.

@mark-i-m
Copy link
Member

mark-i-m commented Mar 8, 2020

Opened rust-lang/blog.rust-lang.org#537 to be merged after the move

bors added a commit to rust-lang/rust-clippy that referenced this issue Mar 9, 2020
@bors
Auto merge of #5277 - chrissimpkins:rustc-dev-guide-transition, r=fli…
91d4db4 
…p1995

Update rustc-guide to rustc-dev-guide

The rustc-guide is being renamed to the rustc-dev-guide. The discussion is in rust-lang/rustc-dev-guide#470.

This PR revises rustc-guide to rustc-dev-guide in the Readme Markdown file.

Transition tracker: rust-lang/rustc-dev-guide#602
bors added a commit to rust-lang/rust-clippy that referenced this issue Mar 9, 2020
@bors
Auto merge of #5277 - chrissimpkins:rustc-dev-guide-transition, r=fli…
c3d3c50 
…p1995

Update rustc-guide to rustc-dev-guide

The rustc-guide is being renamed to the rustc-dev-guide. The discussion is in rust-lang/rustc-dev-guide#470.

This PR revises rustc-guide to rustc-dev-guide in the Readme Markdown file.

Transition tracker: rust-lang/rustc-dev-guide#602

changelog: none
@chrissimpkins
Copy link
Member Author

chrissimpkins commented Mar 10, 2020 •
edited
Loading

https://rustc-dev-guide.rust-lang.org/ is showing 404 pages today

cc @RalfJung re: rust-lang/const-eval#39 (comment)

@JohnTitor
Copy link
Member

@chrissimpkins Oops, it's my fault. I'll fix it shortly.

@JohnTitor
Copy link
Member

Because travis doesn't have config for CNAME, they won't add it when deploying.

@chrissimpkins
Copy link
Member Author

chrissimpkins commented Mar 10, 2020 •
edited
Loading

How do you fix/work around the issue?

@JohnTitor
Copy link
Member

Opened #608, should fix the issue.

@chrissimpkins
Copy link
Member Author

chrissimpkins commented Mar 10, 2020 •
edited
Loading

@JohnTitor verified that https://rustc-dev-guide.rust-lang.org/ is fixed 👍

Mark-Simulacrum pushed a commit to rust-lang/chalk that referenced this issue Mar 10, 2020
@chrissimpkins
Update rustc-guide to rustc-dev-guide (#344)
981a3cc 
* update rustc-guide to rustc-dev-guide

rust-lang/rustc-dev-guide#602
Mark-Simulacrum pushed a commit to rust-lang/blog.rust-lang.org that referenced this issue Mar 10, 2020
@chrissimpkins
Transition rustc-guide to rustc-dev-guide (#535)
2dca227 
See also rust-lang/rustc-dev-guide#602.
@chrissimpkins
Copy link
Member Author

We've moved! :)

@chrissimpkins chrissimpkins mentioned this issue Mar 10, 2020
Closed
@chrissimpkins
Copy link
Member Author

chrissimpkins commented Mar 10, 2020 •
edited
Loading

Added new TODO item to address localizations of the www.rust-lang.org website. Some of the translations are based on the "rustc guide" / "Rustc Guide" name. See: rust-lang/www.rust-lang.org#1029 (comment)

@chrissimpkins
Copy link
Member Author

Added new TODO item to address localizations of the www.rust-lang.org website. Some of the translations are based on the "rustc guide" / "Rustc Guide" name. See: rust-lang/www.rust-lang.org#1029 (comment)

This was not necessary. Marked as finished

@spastorino
Copy link
Member

Marking once everything is merged check if we lack more links in https://github.com/search?p=2&q=org%3Arust-lang+rust-lang.github.io%2Frustc-guide&type=Code as done since right now it's only rust-gha and prev.rust-lang.org which we decided to not update.

@chrissimpkins
Copy link
Member Author

Still waiting on rust-lang/rust#69898 to close this.

steveklabnik pushed a commit to rust-lang/blog.rust-lang.org that referenced this issue Mar 27, 2020
@chrissimpkins @steveklabnik
Transition rustc-guide to rustc-dev-guide (#535)
44c87f9 
See also rust-lang/rustc-dev-guide#602.
@JohnTitor JohnTitor mentioned this issue Apr 3, 2020
Merged
@mark-i-m mark-i-m closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spastorino spastorino

@chrissimpkins chrissimpkins

@mark-i-m mark-i-m

@LeSeulArtichaut LeSeulArtichaut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@spastorino @chrissimpkins @mark-i-m @JohnTitor @LeSeulArtichaut