Handle pub(restricted) #1013
Merged
Handle pub(restricted) #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit properly handles pub(restricted) as introduced in RFC 1422 [0]. The syntax support was added in rust-lang#971, but they were not correctly formatted. [0] https://github.com/rust-lang/rfcs/blob/master/text/1422-pub-restricted.md Fixes rust-lang#970
| @@ -1817,7 +1814,7 @@ fn rewrite_where_clause(context: &RewriteContext, | |||
| } | |||
|
|
|||
| fn format_header(item_name: &str, ident: ast::Ident, vis: &ast::Visibility) -> Option<String> { | |||
There was a problem hiding this comment.
This can no longer fail, right? I guess it should return a String then.
There was a problem hiding this comment.
Done, and propagated up one more call to format_unit_struct :-)
|
This is a great pull request. Solid code, good test coverage and a nice application of r+ with the two nits addressed Thanks! |
The change to `format_visibiilty` means that `format_header` and `format_unit_struct` can no longer fail. Their return type is updated to reflect that.
|
Thanks for the kind words! Re itertools, I am bringing it in in #1007 so I wasn't too bothered about using it here. Also they're all generic methods, so they won't increase code size except when used. It's a super handy crate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit properly handles pub(restricted) as introduced in RFC 1422
[0]. The syntax support was added in #971, but they were not correctly
formatted.
[0] https://github.com/rust-lang/rfcs/blob/master/text/1422-pub-restricted.md
Fixes #970