deps: Update syntex_syntax to 0.31.0 #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the churn on this bump comes from the `Visibility` enum changing
from
pub enum Visibility {
Public,
Inherited,
}
to
pub enum Visibility {
Public,
Crate,
Restricted { path: P<Path>, id: NodeId },
Inherited,
}
which require taking `Visibility` by reference in most places. The new
variants are not handled at this point.
Refs rust-lang#970
Merged
| Visibility::Public => "pub ", | ||
| Visibility::Inherited => "", | ||
| // TODO(#970): Handle new visibility types. | ||
| Visibility::Crate => unimplemented!(), | ||
| Visibility::Restricted { .. } => unimplemented!(), |
There was a problem hiding this comment.
Could we handle these by returning None and then skipping the item, falling back to the missing spans? That is better than panicking, I think.
Also, (nit) if there is an issue number, prefer FIXME to TODO.
|
All looks good, other than the comment on the panics, thanks! |
|
We can land this, but we need syntex 0.32 for the try shorthand. This heroic pull request by antrik includes the required changes. |
|
I'm happy to do another bump. I kind of enjoy the compiler-error chasing that goes with these bumps. Nice break from other stuff sometimes! |
|
Assuming this is acceptable as an approach for handling the |
kamalmarhubi
added a commit
to kamalmarhubi/rustfmt
that referenced
this pull request
May 27, 2016
This commit properly handles pub(restricted) as introduced in RFC 1422 [0]. The syntax support was added in rust-lang#971, but they were not correctly formatted. [0] https://github.com/rust-lang/rfcs/blob/master/text/1422-pub-restricted.md Fixes rust-lang#970
Merged
marcusklaas
pushed a commit
that referenced
this pull request
May 27, 2016
* Handle pub(restricted) This commit properly handles pub(restricted) as introduced in RFC 1422 [0]. The syntax support was added in #971, but they were not correctly formatted. [0] https://github.com/rust-lang/rfcs/blob/master/text/1422-pub-restricted.md Fixes #970 * Drop #[inline] attribute on format_visibility * Make newly non-failing functions return String The change to `format_visibiilty` means that `format_header` and `format_unit_struct` can no longer fail. Their return type is updated to reflect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the churn on this bump comes from the
Visibilityenum changingfrom
to
which require taking
Visibilityby reference in most places. The newvariants are not handled at this point.
Refs #970