-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Issue 4020: problem reformatting block comments #4071
Conversation
@@ -0,0 +1,9 @@ | |||
// rustfmt-wrap_comments: true | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's mentioned in the Contributing docs, but for awareness, when the test is just ensuring rustfmt doesn't modify the formatting like this one you only need the test file under target
and can skip the one under source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that! Removed now.
FWIW, no, I believe this is good to go. Just needs an approval from someone with merge perms. It'll likely be a while longer even after merge before this fix is released and available though due to the current release cycle for rustfmt. |
@calebcartwright is there anything I can do to nudge it along? |
Unfortunately probably not @ahl. There's not a lot of folks on the rustfmt wg, and seems they've been very busy and unavailable recently. Thank you for the PR though, hopefully it won't be too much longer! |
@topecongiro you merged #4079 -- would you mind taking a look at this one? Thanks. |
backported in #4253 |
Fixes #4020
prior to the fix, the tests fail like this: