-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump rustfmt 1.x rustc-ap* crates to v644 #4253
Merged
topecongiro
merged 8 commits into
rust-lang:rustfmt-1.4.18
from
calebcartwright:rustfmt-1.4.18
Jun 13, 2020
Merged
bump rustfmt 1.x rustc-ap* crates to v644 #4253
topecongiro
merged 8 commits into
rust-lang:rustfmt-1.4.18
from
calebcartwright:rustfmt-1.4.18
Jun 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Believe some of the CI failures are likely related to rust-lang/cargo#8351 For example: Caused by:
unable to get packages from source
Caused by:
failed to parse manifest at `/home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/lalrpop-0.19.0/Cargo.toml`
Caused by:
readme file with name '\''../README.md'\'' was not found'
+[[ error: failed to download `lalrpop v0.19.0`
Caused by:
unable to get packages from source
Caused by:
failed to parse manifest at `/home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/lalrpop-0.19.0/Cargo.toml`
Caused by:
readme file with name '../README.md' was not found =~ build failed ]]
+[[ error: failed to download `lalrpop v0.19.0` |
calebcartwright
changed the title
[wip] bump rustfmt 1.x rustc-ap* crates to v644
bump rustfmt 1.x rustc-ap* crates to v644
Jun 12, 2020
topecongiro
approved these changes
Jun 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR with some backportings! LGTM.
This was referenced Jun 13, 2020
This was referenced Oct 27, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs rust-lang/rust#73200, rustfmt 1.x pair to #4252.
There's one last parser bug which has been fixed in source, but that I want to also backport to rustfmt 1.x as part of thisfailure
toanyhow/thiserror
from Switch to std::error::Error for errors #3948 (in part becausefailure
is deprecated and because our subsequent err handling on master is based onanyhow
andthiserror
)