Zulip topic is only renamed for messages after MCP issue rename occurs

[camelid]

It happened here. triagebot renamed the topic of the "renaming this Zulip topic" message, which effectively splits the topic in two, when it should have renamed the topic of the original "new proposal" message.

The code that is responsible for renaming the topic is here:

triagebot/src/handlers/major_change.rs

Lines 138 to 143 in 3272855

	let zulip_update_req = crate::zulip::UpdateMessageApiRequest {
	message_id: zulip_send_res.message_id,
	topic: Some(&new_topic),
	propagate_mode: None,
	content: None,
	};

Another bug is that renaming the Zulip topic breaks the link in the MCP issue—which is what #711 was originally trying to fix (see #701, the short summary is that someone manually renamed the Zulip topic, which broke the link in the MCP issue).

Fixing these issues is probably going to be difficult. I'm not sure what the right solution is.

[camelid]

See also #706, which was another way to approach #701.

[camelid]

@rustbot label: bug

[ghost]

I was recently bit by this and ended up with 3 topics for my MCP. Thankfully the discussion didn't fork and stayed on the originally named topic.

I think this can be fixed by just using the change_all propagate_mode when editing the topic. See also Add API endpoint for renaming topics.

I also just noticed that change_all was already discussed in #701, but based on this comment it looks like the update message API didn't exist at the time and was only added later in #711. I'm not sure if there was some issue originally that prevented change_all from being used in #711 from the start.

I'm going to post a PR as this is just a simple one line fix (in theory...), however I don't have any kind of triagebot dev instance running to test this out myself.

[ghost]

Oh, I've posted my PR, but now I think I may have misunderstood this bug. Is the issue not that the "Zulip topic is only renamed for messages after MCP issue rename occurs", but instead that doing so breaks the links in the MCP?

[camelid]

I think change_all didn't exist before.