Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the entire zulip topic when an MCP issue is renamed. Fixes #1228. #1588

Merged
merged 1 commit into from Mar 13, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 13, 2022

See comment here. Note that I don't have a local dev instance and haven't been able to verify this change myself.

@Mark-Simulacrum
Copy link
Member

Thanks! My guess is this is an API change upstream -- I don't recall seeing https://zulip.com/api/update-message#parameter-propagate_mode before. But this seems like the right setting.

@ghost
Copy link
Author

ghost commented Mar 13, 2022

I think I may have misunderstood this bug possibly, I added an additional comment on #1228. I think the actual issue is that renaming the topic works but would end up breaking the link left on the MCP?

@Mark-Simulacrum Mark-Simulacrum merged commit bc415ec into rust-lang:master Mar 13, 2022
@ghost
Copy link
Author

ghost commented Mar 13, 2022

@Mark-Simulacrum I'm not 100% sure this should be merged based on my last comment, I think my fix may have been premature. (sorry 😿)

@Mark-Simulacrum
Copy link
Member

I think this is the right fix, it may just be incomplete -- we definitely want to update the full thread on Zulip, but it may also be the case that the GitHub link to the Zulip topic is not currently updated. I suspect that should just require clicking through the 'stub' thread left by the renaming though; not really different to today.

@ghost
Copy link
Author

ghost commented Mar 13, 2022

Ok, cool. I'm also reading through Resolving topics breaks links by changing the topic name! and Provide permalinks to reference streams, topics and messages. right now.

I wonder if just having an additional comment posted by rustbot on the github issue would be sufficient? Editing the original comment with an updated link would be nice, but would also be trickier.

@Mark-Simulacrum
Copy link
Member

An additional comment seems OK to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants