Only post suppressed assignment warning when assignment succeeds #2023
Conversation
| r"`{username}` is not on the review rotation at the moment. | ||
| They may take a while to respond. |
There was a problem hiding this comment.
So now we emit a message that a reviewer not on rotation could take a while to respond? What is the reasoning behind this?
In my mind, if I am off-rotation, I just don't want to set expectations about when or if I'll be reviewing again. A message suggesting that "could take a while" it's putting a burden on the person off-rotation.
Can we just make it so, that in case of r? someone the bot just suggests to re-roll to someone else - without doing anything else and let the person issueing the command take a sensible decision?
There was a problem hiding this comment.
So, pretty much everyone that was discussing this on Zulip (in https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Review.20queue.20tracking.20in.20triagebot/with/521048334 and also some other topics) mentioned that they want r? to always work. So that's the rationale for making it work even if the person if off rotation or at their review limit.
The warning just tells the person who requested the review that the requested reviewer is off rotation or at their review limit. Then they can decide to reroll to someone else.
We can modify the warning message to say something like "you may consider rerolling".
There was a problem hiding this comment.
More discussion here: #t-compiler > New triagebot assignment logic respecting PR limits @ 💬.
There was a problem hiding this comment.
We could make this behavior configurable though, that shouldn't be a problem. And allow people to forbid r? <user> if they are off rotation.
To avoid this.