Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a french translation for tools-rustup-windows-2 #2032

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

luidnel-maignan
Copy link
Contributor

@luidnel-maignan luidnel-maignan commented Sep 3, 2024

I was checking the french "tools/install" page from a Windows computer when I noticed that the first paragraph is in English.
It seems to be because there was no value for "tools-rustup-windows-2".
I came to this conclusion based on the Italian version of the webpage, and the content of this variable in the Italian translation files.

So here is a french translation for this variable.
I hope this helps.

Add a translation for tools-rustup-windows-2
@luidnel-maignan luidnel-maignan requested a review from a team as a code owner September 3, 2024 17:07
Copy link
Contributor

@senekor senekor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know some French, so I can review this. At least I should be able to distinguish reasonable from unreasonable translations - this is reasonable.

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also can validate french

@Manishearth Manishearth merged commit 9cb3459 into rust-lang:master Sep 3, 2024
1 check passed
@luidnel-maignan
Copy link
Contributor Author

luidnel-maignan commented Sep 4, 2024

I don't see the translation on the website. Is it just a normal delay ?
Capture d'écran 2024-09-04 143012

@senekor
Copy link
Contributor

senekor commented Sep 4, 2024

The master branch isn't deployed automatically. This PR will trigger a deployment.

@luidnel-maignan
Copy link
Contributor Author

Oh, nice ! Thank you for the info @senekor. And thank you all for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants