-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Histogram (revisited) #9
Histogram (revisited) #9
Conversation
… in add_dimensions
I think this is a good approach. A few thoughts:
|
…o make sure the maximum does not get dropped
…meters from 2 to 1
I managed to address all comments (and I fixed the bug you spotted) - they were all on point, thanks for taking the time to go through the PR with that level of attention! I have also reduced the number of types parameter on With respect to the issue of bin boundaries I proceeded as follows: all strategies now provide an optimal bin width (either directly through the rule they specify or indirectly recasting the optimal number of bins to an optimal bin width) and we make sure that the last edge is strictly greater than the maximum of the array that has been passed to the builder. |
You're welcome. Thanks for working on this! Would you like me to review the updated version, or do you think it's ready to merge?
I think that's fine. For future versions, I think it would be worth investigating how Julia's StatsBase does things, because StatsBase is similar to our implementation in using all half-open intervals (unlike NumPy, which considers the last bin to be a closed interval). |
Let me add a couple of tests and then I think we are good to go!
|
Co-Authored-By: LukeMathWalker <LukeMathWalker@users.noreply.github.com>
Based on our discussion in #8, I have revised the implementation.
It needs a testing suite and a couple more helper methods on
HistogramCounts
but the skeleton it's there. Let me know your thoughts @jturner314