Code

Histogram (revisited)#9

Code

Merged

LukeMathWalker merged 146 commits intorust-ndarray:masterrust-ndarray/ndarray-stats:masterfrom LukeMathWalker:histogram-w-edgesLukeMathWalker/ndarray-stats:histogram-w-edgesCopy head branch name to clipboardNov 18, 2018

+1,411-6

Commits

Commits on Oct 9, 2018

• Adding skeleton provided by jturner

  LukeMathWalker

  committed
  03a3d08

  Copy full SHA for 03a3d08

• Added some IDE-related files

  LukeMathWalker

  committed
  d1e20bf

  Copy full SHA for d1e20bf

• Adding missing pieces - now it compiles

  LukeMathWalker

  committed
  3cdb3ba

  Copy full SHA for 3cdb3ba

Commits on Oct 13, 2018

• Reusing code of from<Vec> in from<Array1>

  

  LukeMathWalker

  committed
  3eedbbc

  Copy full SHA for 3eedbbc

• Fixed bugs, better method names, exported methods needed for doc tests.

  

  LukeMathWalker

  committed
  bbaee7d

  Copy full SHA for bbaee7d

Commits on Oct 14, 2018

• Reorganized code in a submodule

  

  LukeMathWalker

  committed
  7b19061

  Copy full SHA for 7b19061

• Created Bins struct - split code between Bins and Edges

  

  LukeMathWalker

  committed
  acea0a6

  Copy full SHA for acea0a6

• Added get method to Bins

  

  LukeMathWalker

  committed
  b8624a0

  Copy full SHA for b8624a0

• Implemented IntoIterator for Edges

  

  LukeMathWalker

  committed
  cfc59c8

  Copy full SHA for cfc59c8

• Added doc tests for all methods of Edges

  

  LukeMathWalker

  committed
  e8535a4

  Copy full SHA for e8535a4

• Fixed typos

  

  LukeMathWalker

  committed
  837cb67

  Copy full SHA for 837cb67

• All Bins' methods have been documented

  

  LukeMathWalker

  committed
  082ed40

  Copy full SHA for 082ed40

• Fixed typo

  

  LukeMathWalker

  committed
  3897b70

  Copy full SHA for 3897b70

• Better formulation in docs

  

  LukeMathWalker

  committed
  6f8d28f

  Copy full SHA for 6f8d28f

• Fixed typo, better wording

  

  LukeMathWalker

  committed
  9b19ad6

  Copy full SHA for 9b19ad6

Commits on Oct 18, 2018

• Added short docstring to BinNotFound

  LukeMathWalker

  committed
  d93c5d0

  Copy full SHA for d93c5d0

• Improved docstring for get

  LukeMathWalker

  committed
  f7f9dc7

  Copy full SHA for f7f9dc7

• HistogramExt trait has been added with a minimal signature

  LukeMathWalker

  committed
  6419da2

  Copy full SHA for 6419da2

• Removed trait parameter D from HistogramExt trait signature

  LukeMathWalker

  committed
  94d71a2

  Copy full SHA for 94d71a2

• Added docstrings to histogram method

  LukeMathWalker

  committed
  41cc373

  Copy full SHA for 41cc373

• Implemented histogram method; renamed edges to bins in HistogramCounts constructor

  LukeMathWalker

  committed
  0365480

  Copy full SHA for 0365480

• Exporting HistogramExt trait

  LukeMathWalker

  committed
  6420b3f

  Copy full SHA for 6420b3f

• Added ndim field to HistogramCounts to implement dimensionality check in add_dimensions

  LukeMathWalker

  committed
  f728a63

  Copy full SHA for f728a63

• Improving docstring

  LukeMathWalker

  committed
  62c46e8

  Copy full SHA for 62c46e8

• Added docstring to Bins::new

  LukeMathWalker

  committed
  068c893

  Copy full SHA for 068c893

• Removed trailing white line at the end of the file

  LukeMathWalker

  committed
  6d0f7b6

  Copy full SHA for 6d0f7b6

• Checked Edges::from methods

  LukeMathWalker

  committed
  c03945e

  Copy full SHA for c03945e

• Checked right-exclusiveness and left-inclusiveness

  LukeMathWalker

  committed
  71c58ff

  Copy full SHA for 71c58ff

Commits on Oct 23, 2018

• Edges are now duplicates-free

  LukeMathWalker

  committed
  992f969

  Copy full SHA for 992f969

• Removed ndim from the HistogramCounts struct; created a ndim method instead

  LukeMathWalker

  committed
  1ac254c

  Copy full SHA for 1ac254c

• HistogramCounts renamed to Histogram

  LukeMathWalker

  committed
  4e39913

  Copy full SHA for 4e39913

• Added comment to get explaining why it's not implemented using the Index trait for Bins

  LukeMathWalker

  committed
  5315286

  Copy full SHA for 5315286

• Fixed docs

  LukeMathWalker

  committed
  810d25e

  Copy full SHA for 810d25e

• Added docs to histogram submodule; exported HistogramExt as top level trait

  LukeMathWalker

  committed
  89a4af9

  Copy full SHA for 89a4af9

• Revised docstring for HistogramExt

  LukeMathWalker

  committed
  f3f3835

  Copy full SHA for f3f3835

• Added quickcheck test for deduplication

  LukeMathWalker

  committed
  a9dbb1f

  Copy full SHA for a9dbb1f

• Added test for out of bounds access to bins using get

  LukeMathWalker

  committed
  d5266c1

  Copy full SHA for d5266c1

• Added as_view method to Histogram

  LukeMathWalker

  committed
  728556c

  Copy full SHA for 728556c

• Added a doc_test to add_observation

  LukeMathWalker

  committed
  226ea87

  Copy full SHA for 226ea87

• Bins and Edges are now clonable

  LukeMathWalker

  committed
  810f74b

  Copy full SHA for 810f74b

• add_observation doctest is now green

  LukeMathWalker

  committed
  848b61f

  Copy full SHA for 848b61f

• Added grid method to Histogram to access self.bins

  LukeMathWalker

  committed
  18d64f3

  Copy full SHA for 18d64f3

Commits on Oct 25, 2018

• Added grid submodule to histogram submodule

  LukeMathWalker

  committed
  a4490a4

  Copy full SHA for a4490a4

• Added Grid struct

  LukeMathWalker

  committed
  f762f63

  Copy full SHA for f762f63

• Replaced bins with grid in Histogram

  LukeMathWalker

  committed
  f7fa2de

  Copy full SHA for f7fa2de

• Compilation is green

  LukeMathWalker

  committed
  327cb48

  Copy full SHA for 327cb48

Commits on Oct 26, 2018

• Implement From<Vec<Bins<A>>> for Grid. Tests are green

  LukeMathWalker

  committed
  2425da5

  Copy full SHA for 2425da5

• Implement From<Vec<Bins<A>>> for Grid. Tests are green

  LukeMathWalker

  committed
  69710bd

  Copy full SHA for 69710bd

• grid.iter renamed to iter_projections

  LukeMathWalker

  committed
  e1b3d2f

  Copy full SHA for e1b3d2f

• grid.iter renamed to iter_projections

  LukeMathWalker

  committed
  4d5119c

  Copy full SHA for 4d5119c

• index method added to Grid. Histogram.add_observation refactored to use it

  LukeMathWalker

  committed
  812aff5

  Copy full SHA for 812aff5

• Improved docs

  LukeMathWalker

  committed
  29a26f1

  Copy full SHA for 29a26f1

• Added Grid::shape and used it in Histogram constructor

  LukeMathWalker

  committed
  38f4063

  Copy full SHA for 38f4063

• Panic is ensured by grid.index method

  LukeMathWalker

  committed
  40d294f

  Copy full SHA for 40d294f

Commits on Oct 28, 2018

• Added get method to Grid

  LukeMathWalker

  committed
  bd940e7

  Copy full SHA for bd940e7

• Testing the whole histogram matrix in doctest, instead of a single entry

  LukeMathWalker

  committed
  5623ab9

  Copy full SHA for 5623ab9

• Added docstring to Grid

  LukeMathWalker

  committed
  6d5c018

  Copy full SHA for 6d5c018

• Added dosctring to Grid::ndim

  LukeMathWalker

  committed
  735079e

  Copy full SHA for 735079e

• Added docstring to all method on Grid. Remove iter_projections

  LukeMathWalker

  committed
  715e1b6

  Copy full SHA for 715e1b6

• Ignoring Grid sketches, they are not tests

  LukeMathWalker

  committed
  b35e376

  Copy full SHA for b35e376

Commits on Oct 29, 2018

• Added panics notice on Grid::get

  LukeMathWalker

  committed
  7147798

  Copy full SHA for 7147798

• Re-indexed all docs from 0 instead of 1, for consistency with rust notation.

  LukeMathWalker

  committed
  847b955

  Copy full SHA for 847b955

• Minor doc fixes

  LukeMathWalker

  committed
  d7839c2

  Copy full SHA for d7839c2

Commits on Oct 31, 2018

• Bugfix in matrixmultiply is now available in ndarray master branch

  LukeMathWalker

  committed
  3e4022d

  Copy full SHA for 3e4022d

• Adding bins builders

  LukeMathWalker

  committed
  a28aeab

  Copy full SHA for a28aeab

• Brittle implementation of quantile_mut for 1d arrays

  LukeMathWalker

  committed
  2d4e455

  Copy full SHA for 2d4e455

Commits on Nov 1, 2018

• Refactored FreedmanDiaconis implementation

  LukeMathWalker

  committed
  592f749

  Copy full SHA for 592f749

• All important bin building strategies are covered

  LukeMathWalker

  committed
  5ff4b21

  Copy full SHA for 5ff4b21

Commits on Nov 7, 2018

• Added signature for GridBuilder

  LukeMathWalker

  committed
  c949d45

  Copy full SHA for c949d45

• Implemented from_array for GridBuilder

  LukeMathWalker

  committed
  3db5054

  Copy full SHA for 3db5054

• Implemented build for GridBuilder

  LukeMathWalker

  committed
  35f3af0

  Copy full SHA for 35f3af0

• GridBuilder is exported as top level struct

  LukeMathWalker

  committed
  cdaf483

  Copy full SHA for cdaf483

• Explicitly require a view. Refactored builders to match it

  LukeMathWalker

  committed
  ce0180f

  Copy full SHA for ce0180f

Commits on Nov 8, 2018

• Added comment to clarify

  LukeMathWalker

  committed
  4cbd66d

  Copy full SHA for 4cbd66d

• More docs for Grid

  LukeMathWalker

  committed
  7bb3509

  Copy full SHA for 7bb3509

• Added docs to GridBuilder

  LukeMathWalker

  committed
  f2bec0e

  Copy full SHA for f2bec0e

• Added docs to GridBuilder's method

  LukeMathWalker

  committed
  4f2f96b

  Copy full SHA for 4f2f96b

• Renamed BinsBuilder to BinsBuildingStrategy

  LukeMathWalker

  committed
  2c3c590

  Copy full SHA for 2c3c590

• EquiSpaces is private

  LukeMathWalker

  committed
  3dce989

  Copy full SHA for 3dce989

• Added docs to BinsBuildingStrategy

  LukeMathWalker

  committed
  2d563ab

  Copy full SHA for 2d563ab

• Documented bin_width method

  LukeMathWalker

  committed
  0f05d73

  Copy full SHA for 0f05d73

• Docs for all strategies

  LukeMathWalker

  committed
  0d14e53

  Copy full SHA for 0d14e53

• Added detailed docs to all strategies using NumPy as base (almost verbatim)

  LukeMathWalker

  committed
  a48afbb

  Copy full SHA for a48afbb

• Renamed builders submodule to strategies

  LukeMathWalker

  committed
  af41380

  Copy full SHA for af41380

• Errors is not top-level in histogram

  LukeMathWalker

  committed
  543742d

  Copy full SHA for 543742d

• Documented quantile_mut

  LukeMathWalker

  committed
  1a02954

  Copy full SHA for 1a02954

• Added docs to QuantileExt1d

  LukeMathWalker

  committed
  eb78f6d

  Copy full SHA for eb78f6d

Commits on Nov 11, 2018

• Return false for failing tests in quickcheck

  Show description for 7206e72
  

  jturner314

  and

  LukeMathWalker

  authored
  7206e72

  Copy full SHA for 7206e72

• Return false for failing tests in quickcheck

  Show description for cc2376d
  

  jturner314

  and

  LukeMathWalker

  authored
  cc2376d

  Copy full SHA for cc2376d

• rust,ignore => text

  Show description for e11cce7
  

  jturner314

  and

  LukeMathWalker

  authored
  e11cce7

  Copy full SHA for e11cce7

• rust,ignore => text

  Show description for 3139225
  

  jturner314

  and

  LukeMathWalker

  authored
  3139225

  Copy full SHA for 3139225

Commits on Nov 12, 2018

• Fixed typo

  LukeMathWalker

  committed
  3ac076f

  Copy full SHA for 3ac076f

• Added mention of duplicates getting dropped

  LukeMathWalker

  committed
  b6efcfa

  Copy full SHA for b6efcfa

• Destructure a tuple in one go

  LukeMathWalker

  committed
  ca2da4c

  Copy full SHA for ca2da4c

• All methods in one impl block

  LukeMathWalker

  committed
  5801ee0

  Copy full SHA for 5801ee0

• index => index_of; range => range_of

  LukeMathWalker

  committed
  2571829

  Copy full SHA for 2571829

• indexes => indices_of

  LukeMathWalker

  committed
  0042c17

  Copy full SHA for 0042c17

• Clearer inizialization

  LukeMathWalker

  committed
  803ba61

  Copy full SHA for 803ba61

• Using reference instead of view

  LukeMathWalker

  committed
  c2f375b

  Copy full SHA for c2f375b

• Dervice Clone, Debug, Eq and PartialEq for all relevant structs

  LukeMathWalker

  committed
  9a7170b

  Copy full SHA for 9a7170b

• Typo

  LukeMathWalker

  committed
  3ea161c

  Copy full SHA for 3ea161c

• Omitting turbofish notation

  LukeMathWalker

  committed
  1b5c8e3

  Copy full SHA for 1b5c8e3

• Better doc

  LukeMathWalker

  committed
  872cdbd

  Copy full SHA for 872cdbd

• No need to use counters

  LukeMathWalker

  committed
  9e3cc84

  Copy full SHA for 9e3cc84

• Omitting turbofish notation

  LukeMathWalker

  committed
  a89daca

  Copy full SHA for a89daca

• Using reference instead of view, index => index_of

  LukeMathWalker

  committed
  9bc0daa

  Copy full SHA for 9bc0daa

• Avoids cloning

  LukeMathWalker

  committed
  5067686

  Copy full SHA for 5067686

• Shortened imports

  LukeMathWalker

  committed
  fe86055

  Copy full SHA for fe86055

• Add note on ignoring points outside the grid

  LukeMathWalker

  committed
  e348299

  Copy full SHA for e348299

• Fix doctest

  LukeMathWalker

  committed
  17253e5

  Copy full SHA for 17253e5

• Better formatting

  LukeMathWalker

  committed
  c969265

  Copy full SHA for c969265

• Better formatting

  LukeMathWalker

  committed
  56873fe

  Copy full SHA for 56873fe

• Fix parenthesis

  LukeMathWalker

  committed
  b1ce607

  Copy full SHA for b1ce607

• Fixed docs

  LukeMathWalker

  committed
  e8b70ee

  Copy full SHA for e8b70ee

• get => index

  LukeMathWalker

  committed
  b52fa1f

  Copy full SHA for b52fa1f

• Better formatting

  LukeMathWalker

  committed
  6ac45f5

  Copy full SHA for 6ac45f5

• Importing macro without macro_use

  LukeMathWalker

  committed
  eb7d204

  Copy full SHA for eb7d204

• Return option instead of Result from index_of

  LukeMathWalker

  committed
  095b759

  Copy full SHA for 095b759

• get => index

  LukeMathWalker

  committed
  76d60c7

  Copy full SHA for 76d60c7

• Simplified method body

  LukeMathWalker

  committed
  d21b031

  Copy full SHA for d21b031

• Simplified method body

  LukeMathWalker

  committed
  96632c7

  Copy full SHA for 96632c7

• Simplified method body

  LukeMathWalker

  committed
  85cfc26

  Copy full SHA for 85cfc26

• Silence compiler warning

  LukeMathWalker

  committed
  3ed4d3a

  Copy full SHA for 3ed4d3a

• Using ? syntax

  LukeMathWalker

  committed
  d265ea0

  Copy full SHA for d265ea0

• Add Ok(())

  LukeMathWalker

  committed
  10a5b46

  Copy full SHA for 10a5b46

• as_view => counts

  LukeMathWalker

  committed
  42f086a

  Copy full SHA for 42f086a

• Fixed doc tests

  LukeMathWalker

  committed
  3019d9b

  Copy full SHA for 3019d9b

• Bumped Rust version to 1.30

  

  LukeMathWalker

  committed
  8c6411e

  Copy full SHA for 8c6411e

• Reuse quantile_axis_mut implementation

  

  LukeMathWalker

  committed
  f09720c

  Copy full SHA for f09720c

• Convert as_slice to as_array_view

  

  LukeMathWalker

  committed
  3f089a4

  Copy full SHA for 3f089a4

• Fixed broken tests

  

  LukeMathWalker

  committed
  bddf12c

  Copy full SHA for bddf12c

Commits on Nov 13, 2018

• Added expected grid

  LukeMathWalker

  committed
  9e432de

  Copy full SHA for 9e432de

• Fixed FD

  LukeMathWalker

  committed
  f42dcd7

  Copy full SHA for f42dcd7

• Fixed doctest

  LukeMathWalker

  committed
  f6b5dbd

  Copy full SHA for f6b5dbd

• Refactored bin strategies - one extra bin is now added to the right to make sure the maximum does not get dropped

  LukeMathWalker

  committed
  004585f

  Copy full SHA for 004585f

• Added explanation for extra bin to the docs

  LukeMathWalker

  committed
  74723f7

  Copy full SHA for 74723f7

• Using an associated type for BinsBuildingStrategy - reduced type parameters from 2 to 1

  LukeMathWalker

  committed
  a3fc2de

  Copy full SHA for a3fc2de

• Added panics conditions.

  LukeMathWalker

  committed
  5cb53b8

  Copy full SHA for 5cb53b8

Commits on Nov 18, 2018

• Update src/quantile.rs

  Show description for b3c8e0b
  

  jturner314

  and

  LukeMathWalker

  authored
  b3c8e0b

  Copy full SHA for b3c8e0b

• Added test for panic condition

  LukeMathWalker

  committed
  af4a198

  Copy full SHA for af4a198

• For strategies, ask for a reference instead of a view

  LukeMathWalker

  committed
  45cea6a

  Copy full SHA for 45cea6a

• Test panics for Sqrt

  LukeMathWalker

  committed
  fe943e5

  Copy full SHA for fe943e5

• Test Rice panics

  LukeMathWalker

  committed
  bd2570b

  Copy full SHA for bd2570b

• Test Sturges panics

  LukeMathWalker

  committed
  9cfc013

  Copy full SHA for 9cfc013

• Test FreedmanDiaconis panics

  LukeMathWalker

  committed
  77be941

  Copy full SHA for 77be941

• Tested Auto panics

  LukeMathWalker

  committed
  e66f8a6

  Copy full SHA for e66f8a6