feat: support setting initial values for individual variables #75
+124
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnorpelSenf
commented
Dec 30, 2024
Previously, when building up an initial solution from the problem variables would cause repeated reallocation. We support partial initial solutions so we may have 0-n values in the initial solution (with n being the number of total variables). We do not want to allocate memory for all variables because there might be 0 initial values, and we also do not want to do allocate 0 memory because then we have to repeatedly reallocate memory as the initial solution grows. These changes introduce a counter that is incrememted whenever a variable with an initial value is added to the problem. That way, we can allocate the perfect number of bytes upfront in all cases.
|
Please see KnorpelSenf#1 before merging |
lovasoa
approved these changes
Jan 12, 2025
|
Do you know why the assertion fails? |
KnorpelSenf
commented
Jan 12, 2025
| ProblemVariables { variables: vec![] } | ||
| ProblemVariables { | ||
| variables: vec![], | ||
| initial_count: 0, |
There was a problem hiding this comment.
Is this adding to the size? If yes, should we just change the test now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #55 (comment) and below