-
-
Notifications
You must be signed in to change notification settings - Fork 169
Create pull_request_template.md #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
52fa612
to
c63935e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository, I think the file path should be .github/pull_request_template.md
(no templates
subdir).
I left a few suggestions, basically I think we can minimize this down to: is the history reasonably clean, and is the changelog updated.
c63935e
to
dbd0a62
Compare
I simplified the template. What do you think? |
Lgtm! I assume once we merge this then PRs will automatically start showing the new template, we'll see soon :) |
e6375e9
to
5c04775
Compare
Can't merge because we have to merge #502 first :D |
5c04775
to
b67e1ce
Compare
yikes, we should merge it via squash via the Web UI. I accidentally pushed two commits instead of one. Otherwise, give me 5 minutes and I can also fix it by hand. Update Done |
b67e1ce
to
18d9b63
Compare
It's working @GabrielMajeri @nicholasbishop :) |
This is an initial draft for a pull request template. Any comments?
I don't know yet where we can configure this to be used as the default for new PRs. This is the first time that I create a PR template on GitHub
Apparently, GitHub automatically uses this template based on it's file name.