Skip to content

Change Event to be FFI-safe using NonNull #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Change Event to be FFI-safe using NonNull #507

merged 5 commits into from
Oct 17, 2022

Conversation

timrobertsdev
Copy link
Contributor

Addresses #477.

This was a relatively minor change, as seen by the commit. Local tests were run and passed on Windows and Linux (via WSL2).

@phip1611
Copy link
Member

phip1611 commented Sep 7, 2022

Hi @timrobertsdev,
thanks for the PR. I wonder, didn't our new PR template work for you? Or did you just delete it?

I like the change, but this changes the public API as Event is publicly exported, I think. There are currently no constructors yet, and I don't know if or how 3rd part users depend on that type.. so.. should this be part of the changelog? Not sure right now @nicholasbishop @GabrielMajeri @timrobertsdev

@timrobertsdev
Copy link
Contributor Author

@phip1611 The PR template indeed didn't seem to get filled at the time, but I was running a -dev channel browser, so I'm assuming it was a rendering bug. I see it on new PRs on -stable and will be sure to use it going forward, my apologies. Should I amend the initial post with it?

Event is indeed publicly exported and the change could break existing 3rd party code, so I do believe it should be a part of the changelog.

@nicholasbishop
Copy link
Member

I agree that it should be mentioned in the changelog.

Copy link
Member

@nicholasbishop nicholasbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple requested changes: updated Handle docstring and changelog entry.

@GabrielMajeri
Copy link
Collaborator

@timrobertsdev The PR looks good now! Could you also run cargo fmt to fix the failing CI?

@timrobertsdev
Copy link
Contributor Author

@timrobertsdev The PR looks good now! Could you also run cargo fmt to fix the failing CI?

All set.

@nicholasbishop nicholasbishop merged commit f55745c into rust-osdev:main Oct 17, 2022
@nicholasbishop
Copy link
Member

Merged, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants