-
-
Notifications
You must be signed in to change notification settings - Fork 169
Change Event
to be FFI-safe using NonNull
#507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @timrobertsdev, I like the change, but this changes the public API as |
@phip1611 The PR template indeed didn't seem to get filled at the time, but I was running a -dev channel browser, so I'm assuming it was a rendering bug. I see it on new PRs on -stable and will be sure to use it going forward, my apologies. Should I amend the initial post with it?
|
I agree that it should be mentioned in the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple requested changes: updated Handle
docstring and changelog entry.
Improve `Event` docstring.
@timrobertsdev The PR looks good now! Could you also run |
All set. |
Merged, thanks for the PR! |
Addresses #477.
This was a relatively minor change, as seen by the commit. Local tests were run and passed on Windows and Linux (via WSL2).