Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Active from the API #126

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Remove Active from the API #126

merged 3 commits into from
Jun 23, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Jun 17, 2023

Since it's unnecessary and #122 is a breaking change anyways.

@notgull notgull requested a review from Lokathor June 22, 2023 21:26
Lokathor
Lokathor approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Lokathor Lokathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an android expert but if we added this just for them and we don't need it anymore then it's fine to remove.

@notgull notgull merged commit def17a3 into master Jun 23, 2023
@notgull notgull deleted the notgull/fun branch June 23, 2023 03:20
@notgull notgull mentioned this pull request Jun 23, 2023
Closed
MarijnS95
MarijnS95 approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on the idea and justification, haven't reviewed if this is all the active code/comments though but you know better :)

CHANGELOG.md
@@ -3,7 +3,7 @@
## Unreleased

* **Breaking:** `HasRaw(Display/Window)Handle::raw_(display/window)_handle` returns a result indicating if fetching the window handle failed (#122).
* Remove Android-specific platform differences (#118).
* **Breaking:** Remove the `Active/ActiveHandle` types from the public API (#123).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Breaking:** Remove the `Active/ActiveHandle` types from the public API (#123).
* **Breaking:** Remove the `Active/ActiveHandle` types from the public API (#126).

@notgull notgull mentioned this pull request Jun 24, 2023
Closed
@notgull notgull mentioned this pull request Jul 15, 2023
Merged
@MarijnS95 MarijnS95 mentioned this pull request Jul 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lokathor Lokathor Lokathor approved these changes

@MarijnS95 MarijnS95 MarijnS95 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notgull @MarijnS95 @Lokathor