Return error at end of plaintext stream if we saw an EOF on the TLS stream #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The peer is not required to send us `CloseNotify`, but if the socket has shutdown we should act accordingly.
The only way to see an Ok(0) from Connection::read() is via a close_notify alert. Unclean closure (ie, just a TCP EOF without a close_notify) leads to an `UnexpectedEof` from Connection::read(). Applications which want to accept that can do so -- bogo_shim is such an example. Add tests for this and IoState::peer_has_closed()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates #779