Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error at end of plaintext stream if we saw an EOF on the TLS stream #790

Merged
merged 2 commits into from
Jul 24, 2021
Merged

Return error at end of plaintext stream if we saw an EOF on the TLS stream #790

merged 2 commits into from
Jul 24, 2021

Commits on Jul 8, 2021

  1. Interpret end of incoming TLS stream as EOF 

    The peer is not required to send us `CloseNotify`, but if the socket has
shutdown we should act accordingly.
    @djc
    djc committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    83ec91e View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2021

  1. Track clean connection closure 

    The only way to see an Ok(0) from Connection::read() is via a close_notify alert.

Unclean closure (ie, just a TCP EOF without a close_notify) leads
to an `UnexpectedEof` from Connection::read().  Applications which
want to accept that can do so -- bogo_shim is such an example.

Add tests for this and IoState::peer_has_closed()
    @ctz
    ctz committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    0b2b9bf View commit details
    Browse the repository at this point in the history