-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create github action to assign RUSTSEC ids #311
Conversation
@tarcieri can you do a rustsec-admin release so we can move forward with this? |
I'm taking short break from the project but I'll do it when I come back |
|
@tarcieri Cool! Updated! Not sure if there's a great way to test this besides to merge it, then merge something and see if it works. |
title: Assign RUSTSEC IDs | ||
branch: assign-ids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice if we could get these parameterized around the assigned ID somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dos rustsec-admin assign-id
emit that in any way? Can you think of another good way to get that info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It prints it to standard out, although with some additional text. We could potentially add a mode/flag that just prints the ID on success.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(We could also merge this to see if it works and circle back on that particular fixup)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be ok with merging and circling back with the improvement :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Can you flag this PR as ready-to-review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Let's give it a try |
🎉 |
Hrmm, well it failed... I assume because it's attempting to open a PR with no changes to the branch? https://github.com/RustSec/advisory-db/actions/runs/152014712 |
Untested, and won't work until the rustec-admin release happens and we bump the versions in this. But it's got all the right pieces I think.