Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create github action to assign RUSTSEC ids #311

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Create github action to assign RUSTSEC ids #311

merged 2 commits into from
Jun 29, 2020

Conversation

alex
Copy link
Member

@alex alex commented Jun 21, 2020

Untested, and won't work until the rustec-admin release happens and we bump the versions in this. But it's got all the right pieces I think.

@tarcieri tarcieri mentioned this pull request Jun 21, 2020
@alex
Copy link
Member Author

alex commented Jun 27, 2020

@tarcieri can you do a rustsec-admin release so we can move forward with this?

@tarcieri
Copy link
Member

I'm taking short break from the project but I'll do it when I come back

@tarcieri
Copy link
Member

rustsec-admin v0.2.0 is out and I bumped this repo to use it in #321

@alex
Copy link
Member Author

alex commented Jun 29, 2020

@tarcieri Cool! Updated! Not sure if there's a great way to test this besides to merge it, then merge something and see if it works.

Comment on lines +32 to +33
title: Assign RUSTSEC IDs
branch: assign-ids
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice if we could get these parameterized around the assigned ID somehow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dos rustsec-admin assign-id emit that in any way? Can you think of another good way to get that info?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It prints it to standard out, although with some additional text. We could potentially add a mode/flag that just prints the ID on success.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(We could also merge this to see if it works and circle back on that particular fixup)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be ok with merging and circling back with the improvement :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Can you flag this PR as ready-to-review?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@alex alex marked this pull request as ready for review June 29, 2020 22:05
@tarcieri
Copy link
Member

Let's give it a try

@tarcieri tarcieri merged commit 418954a into master Jun 29, 2020
@tarcieri tarcieri deleted the alex-patch-1 branch June 29, 2020 22:08
@alex
Copy link
Member Author

alex commented Jun 29, 2020

🎉

@tarcieri
Copy link
Member

Hrmm, well it failed... I assume because it's attempting to open a PR with no changes to the branch?

https://github.com/RustSec/advisory-db/actions/runs/152014712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants