Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create github action to assign RUSTSEC ids #311

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Create github action to assign RUSTSEC ids #311

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
935c82b
Create github action to assign RUSTSEC ids
alex Jun 21, 2020
d7e8095
Bump
alex Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/assign-ids.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Assign IDs

on:
push:
branches: master

jobs:
assign-ids:
name: Assign IDs
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1

- name: Cache cargo bin
uses: actions/cache@v1
with:
path: ~/.cargo/bin
key: rustsec-admin-v0.2.0

- name: Install rustsec-admin
run: |
if [ ! -f $HOME/.cargo/bin/rustsec-admin ]; then
cargo install rustsec-admin
fi
- name: Assign IDs
run: rustsec-admin assign-id
- name: Create pull request
uses: peter-evans/create-pull-request@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
commit-message: Assign RUSTSEC IDs
title: Assign RUSTSEC IDs
branch: assign-ids
Comment on lines +32 to +33
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice if we could get these parameterized around the assigned ID somehow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dos rustsec-admin assign-id emit that in any way? Can you think of another good way to get that info?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It prints it to standard out, although with some additional text. We could potentially add a mode/flag that just prints the ID on success.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(We could also merge this to see if it works and circle back on that particular fixup)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be ok with merging and circling back with the improvement :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Can you flag this PR as ready-to-review?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!