Add PartialEq/Eq to many js-sys types
#1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
partial-eq
branch
from
8081d65
to
6e7f5f7
Compare
Pauan
approved these changes
Apr 12, 2019
| @@ -2098,6 +2099,14 @@ impl Object { | |||
| } | |||
| } | |||
|
|
|||
| impl PartialEq for Object { | |||
| fn eq(&self, other: &Object) -> bool { | |||
There was a problem hiding this comment.
Should probably be #[inline]
alexcrichton
force-pushed
the
partial-eq
branch
from
6e7f5f7
to
f38193f
Compare
This commit adds `#[derive(PartialEq, Eq)]` to many types throughout `js-sys`. These types are basically all based on `Object`, which means that `Object.is` can be used for `PartialEq` and the `Eq` requirements are upheld. The macro has also been updated to internally store the deref target instead of unconditionally storing `JsValue`, allowing `#[derive]` to work a bit better in these situations.
alexcrichton
force-pushed
the
partial-eq
branch
from
f38193f
to
ba1f67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
#[derive(PartialEq, Eq)]to many types throughoutjs-sys. These types are basically all based onObject, which meansthat
Object.iscan be used forPartialEqand theEqrequirementsare upheld.
The macro has also been updated to internally store the deref target
instead of unconditionally storing
JsValue, allowing#[derive]towork a bit better in these situations.