Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PartialEq/Eq to many js-sys types #1444

Merged
merged 2 commits into from
Apr 12, 2019
Merged

Add PartialEq/Eq to many js-sys types #1444

merged 2 commits into from
Apr 12, 2019

Commits on Apr 12, 2019

  1. Add PartialEq/Eq to many js-sys types 

    This commit adds `#[derive(PartialEq, Eq)]` to many types throughout
`js-sys`. These types are basically all based on `Object`, which means
that `Object.is` can be used for `PartialEq` and the `Eq` requirements
are upheld.

The macro has also been updated to internally store the deref target
instead of unconditionally storing `JsValue`, allowing `#[derive]` to
work a bit better in these situations.
    @alexcrichton
    alexcrichton committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    df8da56 View commit details
    Browse the repository at this point in the history

  2. Remove some unnecessary unsafe in js-sys

    @alexcrichton
    alexcrichton committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    ba1f67d View commit details
    Browse the repository at this point in the history