Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to say that wasm_bindgen::module() is also available with --target web. #3690

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Update docs to say that wasm_bindgen::module() is also available with --target web. #3690

merged 2 commits into from
Nov 10, 2023

Conversation

AlexErrant
Copy link
Contributor

@AlexErrant AlexErrant commented Nov 7, 2023 •
edited
Loading

The docs were originally written in this commit with a corresponding runtime check. The runtime check was updated here* , but the corresponding doc was not updated. This PR updates that doc.

* Click to expand the mod.rs diff since Github doesn't load it because it's too large, then ctrl-f is currently only supported.

Separately, what would it take to graduate this API to a non-experiment?

@AlexErrant AlexErrant changed the title Update docs to say that wasm_bindgen::module() is also available with --target-web. Update docs to say that wasm_bindgen::module() is also available with --target web. Nov 7, 2023
daxpedda
daxpedda reviewed Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with moving this to stable, what it exposes is stable after all. WebAssembly.Memory, ``WebAssembly.TableandWebAssembly.Instance.prototype.exports` is already stably exported as well.

Could you go ahead and do that as well in this PR?

daxpedda
daxpedda approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daxpedda daxpedda merged commit f7fdb2f into rustwasm:main Nov 10, 2023
25 checks passed
@AlexErrant AlexErrant mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexErrant @daxpedda