__wbindgen_thread_destroy has optional params

[AlexErrant]

This PR updates the generated TypeScript to reflect the fact that __wbindgen_thread_destroy has optional params.

Ref:

wasm-bindgen/crates/threads-xform/src/lib.rs

Lines 394 to 395 in 9fb3bca

	// if no explicit parameters are passed (i.e. their value is 0) then we assume
	// we're being called from the agent that must be destroyed and rely on its globals

Before:

export interface InitOutput {
  readonly start: () => void;
  readonly run: () => void;
  readonly child_entry_point: (a: number) => void;
  readonly memory: WebAssembly.Memory;
  readonly __wbindgen_malloc: (a: number, b: number) => number;
  readonly __wbindgen_realloc: (a: number, b: number, c: number, d: number) => number;
  readonly __wbindgen_exn_store: (a: number) => void;
  readonly __wbindgen_thread_destroy: (a: number, b: number) => void;
  readonly __wbindgen_start: () => void;
}

After:

export interface InitOutput {
  readonly start: () => void;
  readonly run: () => void;
  readonly child_entry_point: (a: number) => void;
  readonly memory: WebAssembly.Memory;
  readonly __wbindgen_malloc: (a: number, b: number) => number;
  readonly __wbindgen_realloc: (a: number, b: number, c: number, d: number) => number;
  readonly __wbindgen_exn_store: (a: number) => void;
  readonly __wbindgen_thread_destroy: (a?: number, b?: number) => void;
  readonly __wbindgen_start: () => void;
}

Ideally I'd like better names too (a and b) but for the life of me I can't tell if it's in the wasm or not. Maybe just hardcode it since I'm already doing __wbindgen_thread_destroy? 🤷‍♂️ Oh well this is a strict improvement.

[daxpedda]

This is unfortunately hacky :/

As far as I can tell we don't have more information available because we manually insert these functions into the module instead of exposing them with the wasm_bindgen macro. We could still actually add wasm-bindgen style descriptors manually to address this ... but it's questionable if that's worth it.

In any case, this is an improvement nevertheless, I don't see why not to take it.

Could you add a line to the changelog?

[AlexErrant]

This is unfortunately hacky :/

Agreed, but not sure how else to make it cleaner 😅

Also added a changelog for #3690

[daxpedda]

Thank you!

[linonetwo]

Hi, I'm searching for solution for #3818

May I ask, is this renamed to __wbindgen_free?

[daxpedda]

This function is made to destroy spawned threads, not the main instance.