Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust upgrade to LLVM6 breaks wee_alloc #16

Closed
Mirclus opened this issue Feb 11, 2018 · 1 comment · Fixed by #17
Closed

Rust upgrade to LLVM6 breaks wee_alloc #16

Mirclus opened this issue Feb 11, 2018 · 1 comment · Fixed by #17
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Mirclus
Copy link
Contributor

Mirclus commented Feb 11, 2018

wee_alloc fails to build with the latest nightly (and possibly yesterdays as well) and most likely will continue to fail with upcoming versions (target: wasm32-unknown-unknown):

Intrinsic has incorrect return type!
void (i32)* @llvm.wasm.grow.memory.i32
LLVM ERROR: Broken function found, compilation aborted!

This is most likely caused by the upgrade to LLVM 6 (rust-lang/rust#47828), which changed the return type of this intrinsic.

@fitzgen
Copy link
Member

fitzgen commented Feb 11, 2018

Thanks foir the heads up! Should be a pretty easy fix if you're interested in contributing. Just need to change the return type in imp_wam32.rs and make the alloc_pages function take advantage of the return type.

@fitzgen fitzgen added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants