Fix WASM for LLVM6 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
Feb 12, 2018
There was a problem hiding this comment.
Thanks!
We can go ahead and land this now, panicking is fine since that is what we currently do.
However, now that we can check for failure, we can also modify the alloc_pages signature so that the function returns Result<*mut u8, ()> (here and in imp_unix.rs) and properly return and propagate errors.
Interested in doing this as a follow up PR as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the implementation in dlmalloc-rs.
I'm not sure how to handle the error case. Panic? I didn't change the behavior for now.
Also, if I understand the Intrinsic correctly, both input parameter and return value should have the same type. Dlmalloc doesn't follow this either, but it uses a fixed size for the argument. I'm not really sure if this is something that should get changed.
Should fix #16.